Added support for SSL connection & username auth. #189
Conversation
src/crate/crash/command.py
Outdated
| @@ -472,6 +494,34 @@ def main(): | |||
| cmd.exit() | |||
| sys.exit(cmd.exit_code) | |||
|
|
|||
| def test_main(): | |||
There was a problem hiding this comment.
please don't add test related code in this module
There was a problem hiding this comment.
@mfussenegger any suggestion how to test then?
There was a problem hiding this comment.
Would it be possible to extract some smaller methods from main() - which are then suitable to be called from a test?
There was a problem hiding this comment.
ok, makes sense, I'll try it
|
I guess the coverage decrease is a false positive. |
src/crate/crash/command.py
Outdated
| @@ -472,6 +475,24 @@ def main(): | |||
| cmd.exit() | |||
| sys.exit(cmd.exit_code) | |||
|
|
|||
| def createCmd(crate_hosts, error_trace, output_writer, is_tty, args): | |||
There was a problem hiding this comment.
please use snake_case and prefix with _ (also in the tests)
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=========================================
+ Coverage 76.28% 82.1% +5.82%
=========================================
Files 16 16
Lines 2096 1906 -190
=========================================
- Hits 1599 1565 -34
+ Misses 497 341 -156
Continue to review full report at Codecov.
|
|
@chaudum the actual functionality of the params is tested in crate-python. |
1 similar comment
No description provided.