Add possibility to set the statement class #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alexander-schranz
force-pushed
the
patch-1
branch
from
ef8ccb4
to
f51a5fa
Compare
|
Did you know we added support for invoking the test suite easily by using Docker for running CrateDB [1] just the other day? [1] https://github.com/crate/crate-pdo/blob/main/DEVELOP.rst#using-docker |
alexander-schranz
force-pushed
the
patch-1
branch
from
f51a5fa
to
6030a58
Compare
amotl
approved these changes
Apr 27, 2021
|
@amotl thx for the link, works great with docker. Seems like this is green now :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
I currently have no way to test this but we need something to allow to set the statement class from Doctrine DBAL, see also crate/crate-dbal#113 (review).
Checklist