Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Series: Some notebooks are not compatible with pandas 2.x #493

Closed
amotl opened this issue Jun 18, 2024 · 0 comments · Fixed by #496
Closed

Time Series: Some notebooks are not compatible with pandas 2.x #493

amotl opened this issue Jun 18, 2024 · 0 comments · Fixed by #496
Labels
bug Something isn't working

Comments

@amotl
Copy link
Member

amotl commented Jun 18, 2024

Observations

When running a few notebooks on pandas 2.x, errors like those can be observed:

TypeError: Could not convert string 'BerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlinBerlin' to numeric

-- https://github.com/crate/cratedb-examples/actions/runs/8975962618/job/24651748395?pr=430#step:6:1839
-- https://github.com/crate/cratedb-examples/actions/runs/8975962618/job/24651748121?pr=430#step:6:825

References

Evaluations

  • It looks like it is a data shape error.
  • Apparently, Google Colab now strictly uses and requires pandas 2.x since 2024-05-13?

Thoughts

It looks like it is a data shape error. Maybe the way the notebooks are working with pandas needs an update when using more recent pandas 2.x? The string repetition flaw reminds me of the famous »Wat« talk by Gary Bernhardt. ;]

Workaround

As a temporary measure, tests stopped including the corresponding notebook. It will get skipped per cfd1a6c, on behalf of the relevant modernization patch.

Time Series: Skip testing notebooks not compatible with pandas 2.x

  • exploratory_data_analysis.ipynb
  • time-series-decomposition.ipynb

They are not ready for pandas 2.x yet, and block others from being
upgraded.

Originally posted by @amotl in #430 (comment)

@amotl amotl changed the title Time Series: exploratory_data_analysis.ipynb not compatible with pandas 2.x Time Series: Some notebooks not compatible with pandas 2.x Jun 18, 2024
@amotl amotl added the bug Something isn't working label Jun 18, 2024
@amotl amotl changed the title Time Series: Some notebooks not compatible with pandas 2.x Time Series: Some notebooks are not compatible with pandas 2.x Jun 18, 2024
@amotl amotl linked a pull request Jun 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant