Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Series: Update to pandas 2.0 and SQLAlchemy 2.0 #430

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 19, 2024

About

For the time series notebooks, update pandas and SQLAlchemy to use more recent versions.

Details

An alternative to GH-400, where anyone can collaborate on the same branch. This makes sense if it is a long running one, because, for example, when it needs contributions from more people while we go.

References

@amotl amotl force-pushed the collab/update-pandas-sqlalchemy branch 2 times, most recently from 84050af to f85dfbe Compare May 6, 2024 21:21
@amotl amotl mentioned this pull request May 6, 2024
2 tasks
@amotl

This comment was marked as outdated.

@amotl

This comment was marked as outdated.

@amotl amotl changed the title Bump versions of pandas and SQLAlchemy Timeseries: Bump versions of pandas and SQLAlchemy Jun 18, 2024
@amotl amotl force-pushed the collab/update-pandas-sqlalchemy branch 2 times, most recently from 8568ea4 to b622f59 Compare June 18, 2024 07:39
@amotl amotl force-pushed the collab/update-pandas-sqlalchemy branch 2 times, most recently from c97b53a to f9dc60f Compare June 18, 2024 15:38
@amotl amotl changed the title Timeseries: Bump versions of pandas and SQLAlchemy Time Series: Update to pandas 2.2 and SQLAlchemy 2.0 Jun 18, 2024
@amotl amotl force-pushed the collab/update-pandas-sqlalchemy branch from f9dc60f to 6058b7d Compare June 18, 2024 15:39
@amotl amotl force-pushed the collab/update-pandas-sqlalchemy branch from 6058b7d to cbb11e4 Compare June 18, 2024 16:38
@amotl amotl force-pushed the collab/update-pandas-sqlalchemy branch from cbb11e4 to 0d7b74b Compare June 18, 2024 16:43
surister and others added 3 commits June 18, 2024 18:43
- exploratory_data_analysis.ipynb
- time-series-decomposition.ipynb

They are not ready for pandas 2.x yet, and block others from being
upgraded. Apparently, Google Colab now strictly requires pandas 2.x?
@amotl amotl force-pushed the collab/update-pandas-sqlalchemy branch from 0d7b74b to cfd1a6c Compare June 18, 2024 16:44
@amotl amotl changed the title Time Series: Update to pandas 2.2 and SQLAlchemy 2.0 Time Series: Update to pandas 2.0 and SQLAlchemy 2.0 Jun 18, 2024
@amotl amotl marked this pull request as ready for review June 18, 2024 16:50
@amotl
Copy link
Member Author

amotl commented Jun 18, 2024

We've concluded the update to more recent versions of pandas and SQLAlchemy, according to validation capacities of relevant CI jobs.

In order to make it happen, we needed to skip two notebooks from testing on CI, because they are not compatible yet. There is a dedicated issue to track this. Any support is much appreciated.

Copy link
Contributor

@wierdvanderhaar wierdvanderhaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge.

@surister surister merged commit 65c4266 into main Jun 18, 2024
2 checks passed
@surister surister deleted the collab/update-pandas-sqlalchemy branch June 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants