Adjust postgresql.util.StreamWrapper for compatibility with newer Java versions
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaurzhanSakhariev
approved these changes
May 22, 2023
amotl
changed the title
postgresql.util.StreamWrapper for compatibility with newer Javapostgresql.util.StreamWrapper for compatibility with newer Java versions
seut
reviewed
May 23, 2023
| throw e; | ||
| } catch (Throwable e) { | ||
| throw new RuntimeException("Unexpected exception from finalize", e); | ||
| } |
There was a problem hiding this comment.
A bit strange solution for this topic, but I saw that it's coming from the upstream. Can we also add pgjdbc@3ff4197?
There was a problem hiding this comment.
Thanks for your attention. I've added the @SuppressWarnings({"deprecation", "removal"}) annotation.
amotl
force-pushed
the
amo/update-changelog
branch
2 times, most recently
from
d511abf
to
044ff35
Compare
seut
approved these changes
May 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @BaurzhanSakhariev at #44 (comment). Thanks!
The patch resolves this error.