Prepare 1.44.2-dev.0001 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: JSON deserialization setter case priority Fixes the problem of JSON deserialization ignoring the case of setters. Now case-sensitive setter method matches are considered first. Fixes: googleapis#1830. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…oogleapis#1824) * chore: fix URL to ApacheHttpTransport connection management tutorial * chore: formatting * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Part of b/275589993
…oogleapis#1844) When using UriTemplate.expand with a reserved expansion "{+var}", a set of allowed characters must not be encoded. According to section of [3.2.3 Reserved Expansion: {+var}](https://www.rfc-editor.org/rfc/rfc6570#section-3.2.3), unreserved and reserved character should not be escaped. This fix adds the missing characters `#[]` that must not be percent encoded when using reserved expansion. - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes googleapis#1838
* test: adding java 7 build * required check config
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Source-Link: googleapis/synthtool@1fd6dff Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ad9cabee4c022f1aab04a71332369e0c23841062124818a4490f73337f790337 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…#1858) * chore: Update `dependabot.yml` template not to touch pip dependencies Source-Link: googleapis/synthtool@f961eb0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:af2eda87a54601ae7b7b2be5055c17b43ac98a7805b586772db314de8a7d4a1d Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
* chore: Update dependabot.yml Source-Link: googleapis/synthtool@9ad18b6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:c33bd13e1eab022b0499a3afbfb4b93ae10cb8ad89d8203a6343a88b1b78400f Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…yle-plugin to v3.3.0 (googleapis#1801)
…-info-reports-plugin to v3.4.5 (googleapis#1802)
…ncy-plugin to v3.6.0 (googleapis#1804)
…r-plugin to v3.4.1 (googleapis#1811)
* fix: native image configs for google-http-java-client
* feat: add isShutdown in HttpTransport * fix lint * add comment * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * refactor according to code review * restore comment changes * change year * change default implementation --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Need owlbot to ignore `ci.yaml` so that changes in googleapis#1907 can persist.
* chore: Update ci.yaml to setup Java 21 unit testing.
* chore: add native-image-shared-config as the parent and managed image tag with renovate bot
…s#1914) * chore: Create renovate_config_check.yaml Source-Link: googleapis/synthtool@6612ab8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a6aa751984f1e905c3ae5a3aac78fc7b68210626ce91487dc7ff4f0a06f010cc Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* deps: newer grpc-context to override old one * chore: ignoredUnusedDeclaredDependencies
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…1922) * chore: fix declaration of maven-source-plugin for v3.3.0
🤖 I have created a release *beep* *boop* --- ## [1.44.1](https://togithub.com/googleapis/google-http-java-client/compare/v1.44.0...v1.44.1) (2024-01-26) ### Bug Fixes * Fixing declaration of maven-source-plugin for release job ([f555f56](https://togithub.com/googleapis/google-http-java-client/commit/f555f562d44ab83b2cb672fa351c665336043880)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This comment was marked as off-topic.
This comment was marked as off-topic.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to path filters (32)
google-http-client-android-test/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-android/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-apache-v2/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-apache-v2/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client-apache-v2/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client-appengine/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-assembly/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-bom/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-findbugs/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-gson/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-gson/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client-gson/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client-jackson2/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-jackson2/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client-jackson2/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client-protobuf/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-protobuf/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client-protobuf/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client-test/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-test/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client-test/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client-test/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client-test/serialization-config.jsonis excluded by:!**/*.jsongoogle-http-client-xml/pom.xmlis excluded by:!**/*.xmlgoogle-http-client-xml/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client-xml/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client-xml/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client-xml/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client-xml/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client-xml/resource-config.jsonis excluded by:!**/*.jsongoogle-http-client/pom.xmlis excluded by:!**/*.xmlgoogle-http-client/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client/resource-config.jsonis excluded by:!**/*.jsongoogle-http-client/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client/serialization-config.jsonis excluded by:!**/*.jsongoogle-http-client/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client/reflect-config.jsonis excluded by:!**/*.jsongoogle-http-client/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client/resource-config.jsonis excluded by:!**/*.jsonjitpack.ymlis excluded by:!**/*.ymlpom.xmlis excluded by:!**/*.xmlrenovate.jsonis excluded by:!**/*.jsonsamples/dailymotion-simple-cmdline-sample/pom.xmlis excluded by:!**/*.xmlsamples/snippets/pom.xmlis excluded by:!**/*.xml
Files selected for processing (32)
- .github/.OwlBot.lock.yaml (2 hunks)
- .github/dependabot.yml (1 hunks)
- .github/release-please.yml (1 hunks)
- .github/release-trigger.yml (1 hunks)
- .github/sync-repo-settings.yaml (2 hunks)
- .github/workflows/ci-java7.yaml (1 hunks)
- .github/workflows/ci.yaml (1 hunks)
- .github/workflows/renovate_config_check.yaml (1 hunks)
- .kokoro/build.sh (1 hunks)
- .kokoro/nightly/integration.cfg (1 hunks)
- .kokoro/nightly/java11-integration.cfg (1 hunks)
- .kokoro/presubmit/graalvm-native-17.cfg (1 hunks)
- .kokoro/presubmit/graalvm-native-a.cfg (1 hunks)
- .kokoro/presubmit/graalvm-native-b.cfg (1 hunks)
- .kokoro/presubmit/graalvm-native.cfg (1 hunks)
- .kokoro/presubmit/integration.cfg (1 hunks)
- .kokoro/requirements.txt (4 hunks)
- CHANGELOG.md (1 hunks)
- README.md (2 hunks)
- google-http-client-apache-v2/src/main/java/com/google/api/client/http/apache/v2/ApacheHttpTransport.java (1 hunks)
- google-http-client-jackson2/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client-jackson2/native-image.properties (1 hunks)
- google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java (1 hunks)
- google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java (2 hunks)
- google-http-client/src/main/java/com/google/api/client/util/DateTime.java (2 hunks)
- google-http-client/src/main/java/com/google/api/client/util/FieldInfo.java (2 hunks)
- google-http-client/src/main/java/com/google/api/client/util/escape/PercentEscaper.java (1 hunks)
- google-http-client/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client/native-image.properties (1 hunks)
- google-http-client/src/test/java/com/google/api/client/http/UriTemplateTest.java (1 hunks)
- google-http-client/src/test/java/com/google/api/client/util/FieldInfoTest.java (2 hunks)
- google-http-client/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client/native-image.properties (1 hunks)
- owlbot.py (1 hunks)
- versions.txt (1 hunks)
Files not summarized due to errors (1)
- .kokoro/requirements.txt: Error: Message exceeds token limit
Files skipped from review due to trivial changes (9)
- .github/.OwlBot.lock.yaml
- .github/release-trigger.yml
- .kokoro/nightly/integration.cfg
- .kokoro/nightly/java11-integration.cfg
- .kokoro/presubmit/graalvm-native-17.cfg
- .kokoro/presubmit/graalvm-native-b.cfg
- .kokoro/presubmit/integration.cfg
- google-http-client/src/main/resources/META-INF/native-image/com.google.http-client/google-http-client/native-image.properties
- versions.txt
Additional comments: 21
google-http-client/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client/native-image.properties (1)
- 1-6: The
native-image.propertiesfile specifies several test classes (HttpRequestTest,ByteArrayContentTest, etc.) to be initialized at build time. It's unusual to include test classes in the native image configuration, as this file is typically used for configuring production code. Please verify if these test classes are essential for the native image generation process or if they were included unintentionally.google-http-client-jackson2/src/test/resources/META-INF/native-image/com.google.http-client/google-http-client-jackson2/native-image.properties (1)
- 1-7: The
native-image.propertiesfile for the Jackson module includes a mix of Jackson-specific classes (JacksonFactoryTest,JacksonGeneratorTest, etc.) and a utility class from the Google HTTP Client library (StringUtils). While the Jackson classes are expected in this context, please confirm that the inclusion ofStringUtilsis necessary for the native image generation process and that it's directly related to Jackson's functionality within the library..github/workflows/renovate_config_check.yaml (1)
- 1-25: This GitHub Actions workflow is well-structured for validating the Renovate Bot configuration file. It correctly checks out the code, sets up Node.js (version 20), and installs Renovate to run the configuration validator. This ensures that any changes to
renovate.jsonare automatically checked for correctness, which is a good practice for maintaining the quality of the project's dependency management configuration..github/release-please.yml (1)
- 21-24: The addition of the
1.43.xbranch pattern in therelease-please.ymlfile is correctly configured to align with the project's release management strategy. It specifies the necessary settings for handling GitHub releases and version bumping for this branch pattern, ensuring consistency with the project's overall release process..github/dependabot.yml (1)
- 8-19: The updates to the
.github/dependabot.ymlfile correctly disable version updates for Maven and pip dependencies, indicating a strategic choice to userenovate-botand a shared-dependencies BOM for Maven dependency updates. This approach can help streamline dependency management and ensure consistency across projects. Additionally, setting up notifications for security vulnerabilities via a template in the synthtool repository is a good practice for maintaining project security.google-http-client-apache-v2/src/main/java/com/google/api/client/http/apache/v2/ApacheHttpTransport.java (1)
- 49-50: The update of the documentation URL from HTTP to HTTPS is a good practice, enhancing the security and reliability of accessing the linked resource. This change is approved as it aligns with best practices for secure communication.
google-http-client/src/main/java/com/google/api/client/util/FieldInfo.java (2)
- 137-150: The modifications to the
settersMethodForFieldmethod, including adding thefinalmodifier to theFieldparameter and prioritizing case-sensitive matches for setter methods, enhance the method's clarity and efficiency. Prioritizing case-sensitive matches aligns with Java naming conventions and improves the method's logic.- 227-233: Refactoring the
setValuemethod to iterate over all setter methods and attempt to set the value enhances the method's flexibility and maintainability. This approach allows for more robust handling of fields with multiple potential setter methods, improving the method's ability to adapt to different class structures.google-http-client/src/main/java/com/google/api/client/util/escape/PercentEscaper.java (1)
- 74-75: The update to
SAFE_PLUS_RESERVED_CHARS_URLENCODERto include additional characters (/?#[]) for URI Templates reserved expansion aligns with RFC 6570. This change enhances the flexibility and correctness of URI encoding by ensuring that reserved characters in URI Templates are not unnecessarily escaped. It's crucial to validate that all newly included characters are indeed intended for reserved expansion as per RFC 6570 and that their inclusion does not conflict with other URI encoding scenarios within the application.google-http-client/src/test/java/com/google/api/client/http/UriTemplateTest.java (2)
- 326-337: The test method
testExpandTemplates_reservedExpansion_mustNotEscapeReservedCharSetcorrectly verifies that characters from the reserved set (:/?#[]@!$&'()*+,;=) are not escaped during reserved expansion in UriTemplate, in accordance with RFC 6570 Section 3.2.3. This test ensures that the implementation adheres to the standard for reserved character handling in URI Templates. It's well-structured and directly tests the behavior described in the RFC.- 339-350: The test method
testExpandTemplates_reservedExpansion_mustNotEscapeUnreservedCharSetaccurately tests that characters from the unreserved set (-._~) are not escaped during reserved expansion in UriTemplate, which is consistent with RFC 6570 Section 3.2.3. This addition is crucial for validating the correct handling of unreserved characters in URI Templates. The test is clear, concise, and effectively validates the expected behavior.google-http-client/src/main/java/com/google/api/client/util/DateTime.java (1)
- 342-342: The addition of
serialVersionUIDto theRfc3339ParseResultclass is correctly implemented and follows best practices for serializable classes. This ensures that future changes to the class won't affect the serialization compatibility.google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java (1)
- 13-21: The notice of modification added by the Cryptomator team is clear and provides useful information, including a link to the original file. This is a good practice for transparency and attribution in open-source projects. However, it's important to ensure that this modification aligns with the project's specific guidelines or practices for attributing modifications, if any exist beyond the Apache License 2.0 requirements.
Please verify that this notice of modification aligns with any specific project guidelines or practices for attributing modifications.
CHANGELOG.md (8)
- 3-3: The version link provided for
1.44.1correctly points to the GitHub comparison betweenv1.44.0andv1.44.1, ensuring users can easily view the changes between these versions.- 8-8: The documentation accurately describes a bug fix related to the
maven-source-pluginfor the release job, providing a direct link to the commit for detailed examination.- 15-15: The addition of the
isShutdownmethod inHttpTransportis correctly documented under the Features section for version1.44.0, with a link to the relevant issue and commit.- 21-21: The documentation of the bug fix related to native image configurations for
google-http-java-clientis clear and includes a link to the issue and the commit that resolved it.- 27-27: The update for
grpc-contextdependency is correctly listed under the Dependencies section for version1.44.0, with a link to the issue and commit.- 45-45: The documentation for the bug fix related to
UriTemplatereserved expansion is accurate and includes links to the issue and the commit that resolved it, as well as a link to a related issue that was closed.- 52-52: The documentation for the bug fix related to JSON deserialization setter case priority is clear and includes a link to the issue and the commit that resolved it.
- 57-57: The update for
project.appengine.versiontov2.0.12is correctly documented under the Dependencies section for version1.43.1, with a link to the issue and commit.
google-http-client/src/main/java/com/google/api/client/util/DateTime.java
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java
Show resolved
Hide resolved
|
@coderabbitai pause |
|
@ People from Google: |
SailReal
reviewed
Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the internal release 1.44.2-dev.0001.
Summary by CodeRabbit
isShutdown()method to check if transport is shutdown inHttpTransport.setValuemethod andsettersMethodForFieldlogic inFieldInfo.PercentEscaper.HttpRequestto add notice of modification by Cryptomator team.httpandhttpsin native-image properties.