Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance storage registry with virtual views and regular expressions. #1570

Merged
merged 12 commits into from
Mar 25, 2021
Merged

Enhance storage registry with virtual views and regular expressions. #1570

merged 12 commits into from
Mar 25, 2021

Conversation

ishank011
Copy link
Contributor

Detailed explanation: #1568
Closes #1568, closes #1143

@update-docs
Copy link

update-docs bot commented Mar 18, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ishank011 ishank011 force-pushed the storage-registry-multiple branch 4 times, most recently from 2848f9f to a1a1d3c Compare March 23, 2021 11:17
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 4 alerts when merging a1a1d3c into c5ec249 - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 4 alerts when merging 7d26007 into c5ec249 - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 2 alerts and fixes 4 when merging bbb5d21 into c5ec249 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unreachable statement

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@ishank011 ishank011 force-pushed the storage-registry-multiple branch 3 times, most recently from d770434 to f7c6426 Compare March 23, 2021 15:46
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 4 alerts when merging f7c6426 into c5ec249 - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 4 alerts when merging 7c4fbb1 into c5ec249 - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@ishank011 ishank011 mentioned this pull request Mar 24, 2021
Merged
@wkloucek wkloucek mentioned this pull request Mar 25, 2021
Merged
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request fixes 4 alerts when merging 060cfc6 into ee4584e - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@ishank011 ishank011 marked this pull request as ready for review March 25, 2021 13:22
@ishank011 ishank011 requested a review from labkode as a code owner March 25, 2021 13:22
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request fixes 4 alerts when merging 99fbe7c into ee4584e - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request fixes 4 alerts when merging 18436a4 into 28e32d8 - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

@ishank011 ishank011 merged commit 538c8bd into cs3org:master Mar 25, 2021
@ishank011 ishank011 deleted the storage-registry-multiple branch March 25, 2021 14:38
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request fixes 4 alerts when merging a89d70a into 28e32d8 - view on LGTM.com

fixed alerts:

  • 3 for Missing error check
  • 1 for Unreachable statement

ffurano pushed a commit to ffurano/reva that referenced this pull request Apr 19, 2021
@ishank011
Enhance storage registry with virtual views and regular expressions. (c…
759858a 
…s3org#1570)
ffurano pushed a commit to ffurano/reva that referenced this pull request Apr 20, 2021
@ishank011
Enhance storage registry with virtual views and regular expressions. (c…
374d671 
…s3org#1570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance storage registry with virtual views Storage and app registry rules should match regexes
1 participant
@ishank011