Skip to content
This repository has been archived by the owner on Jul 15, 2021. It is now read-only.

Symfony 5 support #255

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Symfony 5 support #255

merged 1 commit into from
Nov 26, 2019

Conversation

rvanlaak
Copy link
Contributor

@rvanlaak rvanlaak commented Nov 22, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License Apache License 2.0

Allow installing bundle with Symfony 5.0

Appveyor fix borrowed from symfony/symfony@6194c2a

@rvanlaak rvanlaak force-pushed the symfony-5 branch 2 times, most recently from a9066f6 to 943ae51 Compare November 22, 2019 14:21
@csarrazi
Copy link
Owner

Thanks @rvanlaak !

@rvanlaak
Copy link
Contributor Author

rvanlaak commented Nov 26, 2019

You are welcome! Time for some tagging 🎉

Could you also share some insights on why the middleware classes are separate repos? Given that they also all require Symfony they aren't that portable. I even think the Symfony dependencies could get removed for these repos?

@csarrazi
Copy link
Owner

The rationale for this is that Guzzle is not part of the Symfony project, and other projects want to use the middleware, without necessarily fetch every single dependency.

@rvanlaak
Copy link
Contributor Author

rvanlaak commented Dec 2, 2019

@csarrazi is there work to be done before a new minor can get tagged?

@csarrazi
Copy link
Owner

csarrazi commented Dec 3, 2019

Not really. It's just that I no longer have a personal laptop, so I won't be able to push tags until I find some time to set up something on another machine.

@rvanlaak
Copy link
Contributor Author

rvanlaak commented Dec 3, 2019

Github allows creating tags directly 🎉:

https://github.com/csarrazi/CsaGuzzleBundle/releases/new

@rvanlaak rvanlaak deleted the symfony-5 branch December 3, 2019 10:28
@csarrazi
Copy link
Owner

csarrazi commented Dec 3, 2019

True, but from what I recall, GitHub only creates lightweight tags, and not annotated tags (which are signed and associated to an author). I'll do that in the upcoming days, once I manage to find some time! :)

@rvanlaak
Copy link
Contributor Author

rvanlaak commented Dec 3, 2019

Great! Let us know when you need help 💪

@Surf-N-Code
Copy link

Sorry to bug you on this, but did you find the time yet? :) @csarrazi

@rvanlaak
Copy link
Contributor Author

@csarrazi can you tag the new version?

@mvorisek
Copy link

mvorisek commented Mar 9, 2020

@csarrazi Can a new tagged release be made to reflect this merged PR?

@csarrazi
Copy link
Owner

New release tagged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants