Use the create_objective_function in the pendulum swing up example. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorepants
commented
Feb 7, 2024
| obj, obj_grad = create_objective_function(obj_func, state_symbols, | ||
| specified_symbols, tuple(), | ||
| num_nodes, | ||
| node_time_interval=interval_value) |
There was a problem hiding this comment.
Seems like node_time_interval should be an arg not a kwarg. I don't think there is a case when you wouldn't need to set that. Also, should specified symbols and unknown parameters be kwargs since you make not have them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.