Skip to content

Commit 009fc85

Browse files
SamuelZOUdavem330
authored andcommitted
mISDN: fix possible use-after-free in HFC_cleanup()
This module's remove path calls del_timer(). However, that function does not wait until the timer handler finishes. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling del_timer_sync(), which makes sure the timer handler has finished, and unable to re-schedule itself. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 1c72e6a commit 009fc85

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/isdn/hardware/mISDN/hfcpci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2342,7 +2342,7 @@ static void __exit
23422342
HFC_cleanup(void)
23432343
{
23442344
if (timer_pending(&hfc_tl))
2345-
del_timer(&hfc_tl);
2345+
del_timer_sync(&hfc_tl);
23462346

23472347
pci_unregister_driver(&hfc_driver);
23482348
}

0 commit comments

Comments
 (0)