Skip to content

Commit 010d150

Browse files
committed
drm/i915/display: convert intel_mode_valid_max_plane_size() to intel_display
Going forward, struct intel_display is the main display device data pointer. Convert the intel_mode_valid_max_plane_size() helper to struct intel_display, allowing further conversions elsewhere. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/6e7810c793ecc8ff6a31569830bf162156245668.1739378095.git.jani.nikula@intel.com
1 parent a580ed1 commit 010d150

File tree

6 files changed

+12
-15
lines changed

6 files changed

+12
-15
lines changed

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8497,7 +8497,7 @@ enum drm_mode_status intel_cpu_transcoder_mode_valid(struct intel_display *displ
84978497
}
84988498

84998499
enum drm_mode_status
8500-
intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv,
8500+
intel_mode_valid_max_plane_size(struct intel_display *display,
85018501
const struct drm_display_mode *mode,
85028502
int num_joined_pipes)
85038503
{
@@ -8507,18 +8507,18 @@ intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv,
85078507
* intel_mode_valid() should be
85088508
* sufficient on older platforms.
85098509
*/
8510-
if (DISPLAY_VER(dev_priv) < 9)
8510+
if (DISPLAY_VER(display) < 9)
85118511
return MODE_OK;
85128512

85138513
/*
85148514
* Most people will probably want a fullscreen
85158515
* plane so let's not advertize modes that are
85168516
* too big for that.
85178517
*/
8518-
if (DISPLAY_VER(dev_priv) >= 30) {
8518+
if (DISPLAY_VER(display) >= 30) {
85198519
plane_width_max = 6144 * num_joined_pipes;
85208520
plane_height_max = 4800;
8521-
} else if (DISPLAY_VER(dev_priv) >= 11) {
8521+
} else if (DISPLAY_VER(display) >= 11) {
85228522
plane_width_max = 5120 * num_joined_pipes;
85238523
plane_height_max = 4320;
85248524
} else {

drivers/gpu/drm/i915/display/intel_display.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ void intel_link_compute_m_n(u16 bpp, int nlanes,
424424
u32 intel_plane_fb_max_stride(struct drm_device *drm,
425425
u32 pixel_format, u64 modifier);
426426
enum drm_mode_status
427-
intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv,
427+
intel_mode_valid_max_plane_size(struct intel_display *display,
428428
const struct drm_display_mode *mode,
429429
int num_joined_pipes);
430430
enum drm_mode_status

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1396,7 +1396,6 @@ intel_dp_mode_valid(struct drm_connector *_connector,
13961396
struct intel_display *display = to_intel_display(_connector->dev);
13971397
struct intel_connector *connector = to_intel_connector(_connector);
13981398
struct intel_dp *intel_dp = intel_attached_dp(connector);
1399-
struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
14001399
const struct drm_display_mode *fixed_mode;
14011400
int target_clock = mode->clock;
14021401
int max_rate, mode_rate, max_lanes, max_link_clock;
@@ -1496,7 +1495,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
14961495
if (status != MODE_OK)
14971496
return status;
14981497

1499-
return intel_mode_valid_max_plane_size(dev_priv, mode, num_joined_pipes);
1498+
return intel_mode_valid_max_plane_size(display, mode, num_joined_pipes);
15001499
}
15011500

15021501
bool intel_dp_source_supports_tps3(struct intel_display *display)

drivers/gpu/drm/i915/display/intel_dp_mst.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1462,7 +1462,6 @@ mst_connector_mode_valid_ctx(struct drm_connector *_connector,
14621462
{
14631463
struct intel_connector *connector = to_intel_connector(_connector);
14641464
struct intel_display *display = to_intel_display(connector);
1465-
struct drm_i915_private *i915 = to_i915(display->drm);
14661465
struct intel_dp *intel_dp = connector->mst_port;
14671466
struct drm_dp_mst_topology_mgr *mgr = &intel_dp->mst_mgr;
14681467
struct drm_dp_mst_port *port = connector->port;
@@ -1565,7 +1564,7 @@ mst_connector_mode_valid_ctx(struct drm_connector *_connector,
15651564
return 0;
15661565
}
15671566

1568-
*status = intel_mode_valid_max_plane_size(i915, mode, num_joined_pipes);
1567+
*status = intel_mode_valid_max_plane_size(display, mode, num_joined_pipes);
15691568
return 0;
15701569
}
15711570

drivers/gpu/drm/i915/display/intel_dsi.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,14 @@ int intel_dsi_get_modes(struct drm_connector *connector)
6060
enum drm_mode_status intel_dsi_mode_valid(struct drm_connector *connector,
6161
struct drm_display_mode *mode)
6262
{
63-
struct drm_i915_private *dev_priv = to_i915(connector->dev);
63+
struct intel_display *display = to_intel_display(connector->dev);
6464
struct intel_connector *intel_connector = to_intel_connector(connector);
6565
const struct drm_display_mode *fixed_mode =
6666
intel_panel_fixed_mode(intel_connector, mode);
67-
int max_dotclk = to_i915(connector->dev)->display.cdclk.max_dotclk_freq;
67+
int max_dotclk = display->cdclk.max_dotclk_freq;
6868
enum drm_mode_status status;
6969

70-
drm_dbg_kms(&dev_priv->drm, "\n");
70+
drm_dbg_kms(display->drm, "\n");
7171

7272
status = intel_panel_mode_valid(intel_connector, mode);
7373
if (status != MODE_OK)
@@ -76,7 +76,7 @@ enum drm_mode_status intel_dsi_mode_valid(struct drm_connector *connector,
7676
if (fixed_mode->clock > max_dotclk)
7777
return MODE_CLOCK_HIGH;
7878

79-
return intel_mode_valid_max_plane_size(dev_priv, mode, 1);
79+
return intel_mode_valid_max_plane_size(display, mode, 1);
8080
}
8181

8282
struct intel_dsi_host *intel_dsi_host_init(struct intel_dsi *intel_dsi,

drivers/gpu/drm/i915/display/intel_hdmi.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2015,7 +2015,6 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
20152015
{
20162016
struct intel_display *display = to_intel_display(connector->dev);
20172017
struct intel_hdmi *hdmi = intel_attached_hdmi(to_intel_connector(connector));
2018-
struct drm_i915_private *dev_priv = to_i915(display->drm);
20192018
enum drm_mode_status status;
20202019
int clock = mode->clock;
20212020
int max_dotclk = to_i915(connector->dev)->display.cdclk.max_dotclk_freq;
@@ -2068,7 +2067,7 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
20682067
return status;
20692068
}
20702069

2071-
return intel_mode_valid_max_plane_size(dev_priv, mode, 1);
2070+
return intel_mode_valid_max_plane_size(display, mode, 1);
20722071
}
20732072

20742073
bool intel_hdmi_bpc_possible(const struct intel_crtc_state *crtc_state,

0 commit comments

Comments
 (0)