wifi: iwlegacy: do not skip frames with bad FCS

abatyiev · Kalle Valo · commit 02b682d54598 · 2024-05-14T16:31:09.000+03:00
Monitor/sniffer mode benefits from all types of frames, even if FCS check fails. But we must mark frames as such. Tested on iwl3945 only. Signed-off-by: Andrii Batyiev <batyiev@gmail.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://msgid.link/20240509101140.32664-1-batyiev@gmail.com
diff --git a/drivers/net/wireless/intel/iwlegacy/3945.c b/drivers/net/wireless/intel/iwlegacy/3945.c
@@ -566,7 +566,7 @@ il3945_hdl_rx(struct il_priv *il, struct il_rx_buf *rxb)
 	if (!(rx_end->status & RX_RES_STATUS_NO_CRC32_ERROR) ||
 	    !(rx_end->status & RX_RES_STATUS_NO_RXE_OVERFLOW)) {
 		D_RX("Bad CRC or FIFO: 0x%08X.\n", rx_end->status);
-		return;
+		rx_status.flag |= RX_FLAG_FAILED_FCS_CRC;
 	}
 
 	/* Convert 3945's rssi indicator to dBm */
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -664,7 +664,7 @@ il4965_hdl_rx(struct il_priv *il, struct il_rx_buf *rxb)
 	if (!(rx_pkt_status & RX_RES_STATUS_NO_CRC32_ERROR) ||
 	    !(rx_pkt_status & RX_RES_STATUS_NO_RXE_OVERFLOW)) {
 		D_RX("Bad CRC or FIFO: 0x%08X.\n", le32_to_cpu(rx_pkt_status));
-		return;
+		rx_status.flag |= RX_FLAG_FAILED_FCS_CRC;
 	}
 
 	/* This will be used in several places later */

Original file line number	Diff line number	Diff line change
`@@ -566,7 +566,7 @@ il3945_hdl_rx(struct il_priv il, struct il_rx_buf rxb)`
`566`	`566`	`if (!(rx_end->status & RX_RES_STATUS_NO_CRC32_ERROR) \|\|`
`567`	`567`	`!(rx_end->status & RX_RES_STATUS_NO_RXE_OVERFLOW)) {`
`568`	`568`	`D_RX("Bad CRC or FIFO: 0x%08X.\n", rx_end->status);`
`569`		`- return;`
	`569`	`+ rx_status.flag \|= RX_FLAG_FAILED_FCS_CRC;`
`570`	`570`	`}`
`571`	`571`
`572`	`572`	`/* Convert 3945's rssi indicator to dBm */`
Original file line number	Diff line number	Diff line change
`@@ -664,7 +664,7 @@ il4965_hdl_rx(struct il_priv il, struct il_rx_buf rxb)`
`664`	`664`	`if (!(rx_pkt_status & RX_RES_STATUS_NO_CRC32_ERROR) \|\|`
`665`	`665`	`!(rx_pkt_status & RX_RES_STATUS_NO_RXE_OVERFLOW)) {`
`666`	`666`	`D_RX("Bad CRC or FIFO: 0x%08X.\n", le32_to_cpu(rx_pkt_status));`
`667`		`- return;`
	`667`	`+ rx_status.flag \|= RX_FLAG_FAILED_FCS_CRC;`
`668`	`668`	`}`
`669`	`669`
`670`	`670`	`/* This will be used in several places later */`