Skip to content

Commit 03ac738

Browse files
Colin Ian Kingdavem330
authored andcommitted
rtnetlink: fix missing size for IFLA_IF_NETNSID
The size for IFLA_IF_NETNSID is missing from the size calculation because the proceeding semicolon was not removed. Fix this by removing the semicolon. Detected by CoverityScan, CID#1461135 ("Structurally dead code") Fixes: 79e1ad1 ("rtnetlink: use netnsid to query interface") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Jiri Benc <jbenc@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ac71a1f commit 03ac738

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/core/rtnetlink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -920,7 +920,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
920920
+ rtnl_xdp_size() /* IFLA_XDP */
921921
+ nla_total_size(4) /* IFLA_EVENT */
922922
+ nla_total_size(4) /* IFLA_NEW_NETNSID */
923-
+ nla_total_size(1); /* IFLA_PROTO_DOWN */
923+
+ nla_total_size(1) /* IFLA_PROTO_DOWN */
924924
+ nla_total_size(4) /* IFLA_IF_NETNSID */
925925
+ 0;
926926
}

0 commit comments

Comments
 (0)