PCI: qcom: Prevent use of uninitialized data in qcom_pcie_suspend_noirq()

Dan Carpenter · kwilczynski · commit 044b45be04cb · 2024-07-10T05:39:15.000Z
Smatch complains that "ret" could be uninitialized if "pcie->icc_mem" is NULL and "pm_suspend_target_state == PM_SUSPEND_MEM". Silence this warning by initializing ret to zero. Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") Link: https://lore.kernel.org/linux-pci/20240708180539.1447307-4-dan.carpenter@linaro.org Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Anders Roxell <anders.roxell@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1637,7 +1637,7 @@ static int qcom_pcie_probe(struct platform_device *pdev)
 static int qcom_pcie_suspend_noirq(struct device *dev)
 {
 	struct qcom_pcie *pcie = dev_get_drvdata(dev);
-	int ret;
+	int ret = 0;
 
 	/*
 	 * Set minimum bandwidth required to keep data path functional during

Original file line number	Diff line number	Diff line change
`@@ -1637,7 +1637,7 @@ static int qcom_pcie_probe(struct platform_device *pdev)`
`1637`	`1637`	`static int qcom_pcie_suspend_noirq(struct device *dev)`
`1638`	`1638`	`{`
`1639`	`1639`	`struct qcom_pcie *pcie = dev_get_drvdata(dev);`
`1640`		`- int ret;`
	`1640`	`+ int ret = 0;`
`1641`	`1641`
`1642`	`1642`	`/*`
`1643`	`1643`	`* Set minimum bandwidth required to keep data path functional during`