mm/page_alloc: remove unnecessary __maybe_unused in order_to_pindex()

qiyeliu · akpm00 · commit 0a1e082b64cc · 2025-03-21T22:03:17.000-07:00
The `movable` variable is always used when `CONFIG_TRANSPARENT_HUGEPAGE` is enabled, so the `__maybe_unused` attribute is not necessary. This patch removes it and keeps the variable declaration within the `#ifdef` block for better clarity. Link: https://lkml.kernel.org/r/20250319091726.401158-1-liuyerd@163.com Signed-off-by: Liu Ye<liuye@kylinos.cn> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
@@ -509,9 +509,9 @@ static void bad_page(struct page *page, const char *reason)
 
 static inline unsigned int order_to_pindex(int migratetype, int order)
 {
-	bool __maybe_unused movable;
 
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
+	bool movable;
 	if (order > PAGE_ALLOC_COSTLY_ORDER) {
 		VM_BUG_ON(order != HPAGE_PMD_ORDER);
 

Original file line number	Diff line number	Diff line change
`@@ -509,9 +509,9 @@ static void bad_page(struct page page, const char reason)`
`509`	`509`
`510`	`510`	`static inline unsigned int order_to_pindex(int migratetype, int order)`
`511`	`511`	`{`
`512`		`- bool __maybe_unused movable;`
`513`	`512`
`514`	`513`	`#ifdef CONFIG_TRANSPARENT_HUGEPAGE`
	`514`	`+ bool movable;`
`515`	`515`	`if (order > PAGE_ALLOC_COSTLY_ORDER) {`
`516`	`516`	`VM_BUG_ON(order != HPAGE_PMD_ORDER);`
`517`	`517`