Skip to content

Commit 0a3b94a

Browse files
committed
drm/i915/selftest: Ensure string fits within name[]
Shrink the strncpy bounds to ensure the NUL-terminator can fit within the embedded array: In file included from drivers/gpu/drm/i915/gem/i915_gem_context.c:2475: drivers/gpu/drm/i915/gem/selftests/mock_context.c: In function ‘mock_context’: drivers/gpu/drm/i915/gem/selftests/mock_context.c:40:3: error: ‘strncpy’ specified bound 24 equals destination size [-Werror=stringop-truncation] 40 | strncpy(ctx->name, name, sizeof(ctx->name)); Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200203181625.589118-1-chris@chris-wilson.co.uk
1 parent bb5e439 commit 0a3b94a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/i915/gem/selftests/mock_context.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ mock_context(struct drm_i915_private *i915,
3737
if (name) {
3838
struct i915_ppgtt *ppgtt;
3939

40-
strncpy(ctx->name, name, sizeof(ctx->name));
40+
strncpy(ctx->name, name, sizeof(ctx->name) - 1);
4141

4242
ppgtt = mock_ppgtt(i915, name);
4343
if (!ppgtt)

0 commit comments

Comments
 (0)