Skip to content

Commit 0c12028

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: refine the EOF check in blkdev_iomap_begin
blkdev_iomap_begin rounds down the offset to the logical block size before stashing it in iomap->offset and checking that it still is inside the inode size. Check the i_size check to the raw pos value so that we don't try a zero size write if iter->pos is unaligned. Fixes: 487c607 ("block: use iomap for writes to block devices") Reported-by: syzbot+0a3683a0a6fecf909244@syzkaller.appspotmail.com Signed-off-by: Christoph Hellwig <hch@lst.de> Tested-by: syzbot+0a3683a0a6fecf909244@syzkaller.appspotmail.com Link: https://lore.kernel.org/r/20240503081042.2078062-1-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent a4217c6 commit 0c12028

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

block/fops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
385385

386386
iomap->bdev = bdev;
387387
iomap->offset = ALIGN_DOWN(offset, bdev_logical_block_size(bdev));
388-
if (iomap->offset >= isize)
388+
if (offset >= isize)
389389
return -EIO;
390390
iomap->type = IOMAP_MAPPED;
391391
iomap->addr = iomap->offset;

0 commit comments

Comments
 (0)