Skip to content

Commit 0dd945f

Browse files
committed
genirq/cpuhotplug: Remove irq disabling logic
This is called from stop_machine() with interrupts disabled. No point in disabling them some more. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Keith Busch <keith.busch@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Christoph Hellwig <hch@lst.de> Link: http://lkml.kernel.org/r/20170619235445.198042748@linutronix.de
1 parent 137221d commit 0dd945f

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

kernel/irq/cpuhotplug.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,8 @@ static bool migrate_one_irq(struct irq_desc *desc)
5959
*/
6060
void irq_migrate_all_off_this_cpu(void)
6161
{
62-
unsigned int irq;
6362
struct irq_desc *desc;
64-
unsigned long flags;
65-
66-
local_irq_save(flags);
63+
unsigned int irq;
6764

6865
for_each_active_irq(irq) {
6966
bool affinity_broken;
@@ -73,10 +70,9 @@ void irq_migrate_all_off_this_cpu(void)
7370
affinity_broken = migrate_one_irq(desc);
7471
raw_spin_unlock(&desc->lock);
7572

76-
if (affinity_broken)
77-
pr_warn_ratelimited("IRQ%u no longer affine to CPU%u\n",
73+
if (affinity_broken) {
74+
pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
7875
irq, smp_processor_id());
76+
}
7977
}
80-
81-
local_irq_restore(flags);
8278
}

0 commit comments

Comments
 (0)