Skip to content

Commit 101e5c5

Browse files
Dan Carpenterkwilczynski
authored andcommitted
PCI: qcom: Fix missing error code in qcom_pcie_probe()
Return a negative error code if dev_pm_opp_find_freq_floor() fails; don't return success. Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") Link: https://lore.kernel.org/linux-pci/20240708180539.1447307-2-dan.carpenter@linaro.org Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Anders Roxell <anders.roxell@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
1 parent 5b6272e commit 101e5c5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/pci/controller/dwc/pcie-qcom.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1578,7 +1578,8 @@ static int qcom_pcie_probe(struct platform_device *pdev)
15781578
if (!ret) {
15791579
opp = dev_pm_opp_find_freq_floor(dev, &max_freq);
15801580
if (IS_ERR(opp)) {
1581-
dev_err_probe(pci->dev, PTR_ERR(opp),
1581+
ret = PTR_ERR(opp);
1582+
dev_err_probe(pci->dev, ret,
15821583
"Unable to find max freq OPP\n");
15831584
goto err_pm_runtime_put;
15841585
} else {

0 commit comments

Comments
 (0)