scsi: smartpqi_init: fix boolean expression in pqi_device_remove_start

GustavoARSilva · martinkpetersen · commit 12de280b36f0 · 2019-01-08T21:57:26.000-05:00
Fix boolean expression by using logical AND operator '&&' instead of bitwise operator '&'. This issue was detected with the help of Coccinelle. Fixes: 1e46731 ("scsi: smartpqi: check for null device pointers") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Don Brace <don.brace@microsemi.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -323,7 +323,7 @@ static inline void pqi_device_remove_start(struct pqi_scsi_dev *device)
 static inline bool pqi_device_in_remove(struct pqi_ctrl_info *ctrl_info,
 					struct pqi_scsi_dev *device)
 {
-	return device->in_remove & !ctrl_info->in_shutdown;
+	return device->in_remove && !ctrl_info->in_shutdown;
 }
 
 static inline void pqi_schedule_rescan_worker_with_delay(

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ static inline void pqi_device_remove_start(struct pqi_scsi_dev *device)`
`323`	`323`	`static inline bool pqi_device_in_remove(struct pqi_ctrl_info *ctrl_info,`
`324`	`324`	`struct pqi_scsi_dev *device)`
`325`	`325`	`{`
`326`		`- return device->in_remove & !ctrl_info->in_shutdown;`
	`326`	`+ return device->in_remove && !ctrl_info->in_shutdown;`
`327`	`327`	`}`
`328`	`328`
`329`	`329`	`static inline void pqi_schedule_rescan_worker_with_delay(`