wifi: ath12k: fix crash when unbinding

jtornosm · Jeff Johnson · commit 1304446f6786 · 2024-10-22T07:42:31.000-07:00
If there is an error during some initialization related to firmware, the function ath12k_dp_cc_cleanup is called to release resources. However this is released again when the device is unbinded (ath12k_pci), and we get: BUG: kernel NULL pointer dereference, address: 0000000000000020 at RIP: 0010:ath12k_dp_cc_cleanup.part.0+0xb6/0x500 [ath12k] Call Trace: ath12k_dp_cc_cleanup ath12k_dp_free ath12k_core_deinit ath12k_pci_remove ... The issue is always reproducible from a VM because the MSI addressing initialization is failing. In order to fix the issue, just set to NULL the released structure in ath12k_dp_cc_cleanup at the end. cc: stable@vger.kernel.org Fixes: d889913 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> Link: https://patch.msgid.link/20241017181004.199589-2-jtornosm@redhat.com Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
@@ -1250,6 +1250,7 @@ static void ath12k_dp_cc_cleanup(struct ath12k_base *ab)
 	}
 
 	kfree(dp->spt_info);
+	dp->spt_info = NULL;
 }
 
 static void ath12k_dp_reoq_lut_cleanup(struct ath12k_base *ab)

Original file line number	Diff line number	Diff line change
`@@ -1250,6 +1250,7 @@ static void ath12k_dp_cc_cleanup(struct ath12k_base *ab)`
`1250`	`1250`	`}`
`1251`	`1251`
`1252`	`1252`	`kfree(dp->spt_info);`
	`1253`	`+ dp->spt_info = NULL;`
`1253`	`1254`	`}`
`1254`	`1255`
`1255`	`1256`	`static void ath12k_dp_reoq_lut_cleanup(struct ath12k_base *ab)`