Skip to content

Commit 1308d7f

Browse files
hreineckehtejun
authored andcommitted
libata: use status bit definitions in ata_dump_status()
Use the bit definitions for better readability. Signed-off-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent 27f00e5 commit 1308d7f

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

drivers/ata/libata-scsi.c

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -799,26 +799,27 @@ static void ata_dump_status(unsigned id, struct ata_taskfile *tf)
799799
if (stat & ATA_BUSY) {
800800
printk("Busy }\n"); /* Data is not valid in this case */
801801
} else {
802-
if (stat & 0x40) printk("DriveReady ");
803-
if (stat & 0x20) printk("DeviceFault ");
804-
if (stat & 0x10) printk("SeekComplete ");
805-
if (stat & 0x08) printk("DataRequest ");
806-
if (stat & 0x04) printk("CorrectedError ");
807-
if (stat & 0x02) printk("Sense ");
808-
if (stat & 0x01) printk("Error ");
802+
if (stat & ATA_DRDY) printk("DriveReady ");
803+
if (stat & ATA_DF) printk("DeviceFault ");
804+
if (stat & ATA_DSC) printk("SeekComplete ");
805+
if (stat & ATA_DRQ) printk("DataRequest ");
806+
if (stat & ATA_CORR) printk("CorrectedError ");
807+
if (stat & ATA_SENSE) printk("Sense ");
808+
if (stat & ATA_ERR) printk("Error ");
809809
printk("}\n");
810810

811811
if (err) {
812812
printk(KERN_WARNING "ata%u: error=0x%02x { ", id, err);
813-
if (err & 0x04) printk("DriveStatusError ");
814-
if (err & 0x80) {
815-
if (err & 0x04) printk("BadCRC ");
813+
if (err & ATA_ABORTED) printk("DriveStatusError ");
814+
if (err & ATA_ICRC) {
815+
if (err & ATA_ABORTED)
816+
printk("BadCRC ");
816817
else printk("Sector ");
817818
}
818-
if (err & 0x40) printk("UncorrectableError ");
819-
if (err & 0x10) printk("SectorIdNotFound ");
820-
if (err & 0x02) printk("TrackZeroNotFound ");
821-
if (err & 0x01) printk("AddrMarkNotFound ");
819+
if (err & ATA_UNC) printk("UncorrectableError ");
820+
if (err & ATA_IDNF) printk("SectorIdNotFound ");
821+
if (err & ATA_TRK0NF) printk("TrackZeroNotFound ");
822+
if (err & ATA_AMNF) printk("AddrMarkNotFound ");
822823
printk("}\n");
823824
}
824825
}

0 commit comments

Comments
 (0)