scsi: lpfc: Correct size for cmdwqe/rspwqe for memset()

musamaanjum · martinkpetersen · commit 16cc2ba71b9f · 2024-03-10T18:17:32.000-04:00
The cmdwqe and rspwqe are of type lpfc_wqe128. They should be memset() with the same type. Fixes: 61910d6 ("scsi: lpfc: SLI path split: Refactor CT paths") Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/r/20240304091119.847060-1-usama.anjum@collabora.com Reviewed-by: Justin Tee <justin.tee@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -3169,10 +3169,10 @@ lpfc_bsg_diag_loopback_run(struct bsg_job *job)
 	}
 
 	cmdwqe = &cmdiocbq->wqe;
-	memset(cmdwqe, 0, sizeof(union lpfc_wqe));
+	memset(cmdwqe, 0, sizeof(*cmdwqe));
 	if (phba->sli_rev < LPFC_SLI_REV4) {
 		rspwqe = &rspiocbq->wqe;
-		memset(rspwqe, 0, sizeof(union lpfc_wqe));
+		memset(rspwqe, 0, sizeof(*rspwqe));
 	}
 
 	INIT_LIST_HEAD(&head);

Original file line number	Diff line number	Diff line change
`@@ -3169,10 +3169,10 @@ lpfc_bsg_diag_loopback_run(struct bsg_job *job)`
`3169`	`3169`	`}`
`3170`	`3170`
`3171`	`3171`	`cmdwqe = &cmdiocbq->wqe;`
`3172`		`- memset(cmdwqe, 0, sizeof(union lpfc_wqe));`
	`3172`	`+ memset(cmdwqe, 0, sizeof(*cmdwqe));`
`3173`	`3173`	`if (phba->sli_rev < LPFC_SLI_REV4) {`
`3174`	`3174`	`rspwqe = &rspiocbq->wqe;`
`3175`		`- memset(rspwqe, 0, sizeof(union lpfc_wqe));`
	`3175`	`+ memset(rspwqe, 0, sizeof(*rspwqe));`
`3176`	`3176`	`}`
`3177`	`3177`
`3178`	`3178`	`INIT_LIST_HEAD(&head);`