Skip to content

Commit 16fdb3c

Browse files
committed
Revert "drm/tegra: Use dma_buf from GEM object instance"
This reverts commit 482c7e2. The dma_buf field in struct drm_gem_object is not stable over the object instance's lifetime. The field becomes NULL when user space releases the final GEM handle on the buffer object. This resulted in a NULL-pointer deref. Workarounds in commit 5307dce ("drm/gem: Acquire references on GEM handles for framebuffers") and commit f6bfc9a ("drm/framebuffer: Acquire internal references on GEM handles") only solved the problem partially. They especially don't work for buffer objects without a DRM framebuffer associated. Hence, this revert to going back to using .import_attach->dmabuf. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> Link: https://lore.kernel.org/r/20250715084549.41473-1-tzimmermann@suse.de
1 parent e228e7d commit 16fdb3c

File tree

1 file changed

+1
-1
lines changed
  • drivers/gpu/drm/tegra

1 file changed

+1
-1
lines changed

drivers/gpu/drm/tegra/gem.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ void tegra_bo_free_object(struct drm_gem_object *gem)
526526
if (drm_gem_is_imported(gem)) {
527527
dma_buf_unmap_attachment_unlocked(gem->import_attach, bo->sgt,
528528
DMA_TO_DEVICE);
529-
dma_buf_detach(gem->dma_buf, gem->import_attach);
529+
dma_buf_detach(gem->import_attach->dmabuf, gem->import_attach);
530530
}
531531
}
532532

0 commit comments

Comments
 (0)