Skip to content

Commit 172e269

Browse files
Edward Creedavem330
authored andcommitted
sfc: ef10: fix TX queue lookup in TX event handling
We're starting from a TXQ label, not a TXQ type, so efx_channel_get_tx_queue() is inappropriate. This worked by chance, because labels and types currently match on EF10, but we shouldn't rely on that. Fixes: 1280479 ("sfc: decouple TXQ type from label") Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 83b09a1 commit 172e269

File tree

1 file changed

+1
-2
lines changed
  • drivers/net/ethernet/sfc

1 file changed

+1
-2
lines changed

drivers/net/ethernet/sfc/ef10.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2928,8 +2928,7 @@ efx_ef10_handle_tx_event(struct efx_channel *channel, efx_qword_t *event)
29282928

29292929
/* Get the transmit queue */
29302930
tx_ev_q_label = EFX_QWORD_FIELD(*event, ESF_DZ_TX_QLABEL);
2931-
tx_queue = efx_channel_get_tx_queue(channel,
2932-
tx_ev_q_label % EFX_MAX_TXQ_PER_CHANNEL);
2931+
tx_queue = channel->tx_queue + (tx_ev_q_label % EFX_MAX_TXQ_PER_CHANNEL);
29332932

29342933
if (!tx_queue->timestamping) {
29352934
/* Transmit completion */

0 commit comments

Comments
 (0)