Skip to content

Commit 174722d

Browse files
author
Kent Overstreet
committed
bcachefs: Delete old assertion for online fsck
the order in which btree_gc walks keys have changed, so we no longer have the sort of issues with online fsck this assertion was warning about. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
1 parent 38ad9dc commit 174722d

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

fs/bcachefs/btree_trans_commit.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -603,20 +603,13 @@ static int bch2_trans_commit_run_triggers(struct btree_trans *trans)
603603

604604
static noinline int bch2_trans_commit_run_gc_triggers(struct btree_trans *trans)
605605
{
606-
trans_for_each_update(trans, i) {
607-
/*
608-
* XXX: synchronization of cached update triggers with gc
609-
* XXX: synchronization of interior node updates with gc
610-
*/
611-
BUG_ON(i->cached || i->level);
612-
606+
trans_for_each_update(trans, i)
613607
if (btree_node_type_needs_gc(__btree_node_type(i->level, i->btree_id)) &&
614608
gc_visited(trans->c, gc_pos_btree_node(insert_l(trans, i)->b))) {
615609
int ret = run_one_mem_trigger(trans, i, i->flags|BTREE_TRIGGER_gc);
616610
if (ret)
617611
return ret;
618612
}
619-
}
620613

621614
return 0;
622615
}

0 commit comments

Comments
 (0)