Skip to content

Commit 1965dbd

Browse files
committed
drm/i915/bios: Use the platform's port_mask when there is no VBT
When we have no VBT we currently assume ports A-F are all pontially valid for every platform. That is nonsense. Grab the bitmask of valid ports from the runtime info instead. Although the defaults we actually fill here look semi-sensible only for hsw-skl era hardware. Dunno if we should try to do something more appropriate here for other platforms, or just try to nuke the whole thing? Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240319092443.15769-2-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com>
1 parent 2641089 commit 1965dbd

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/gpu/drm/i915/display/intel_bios.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2890,9 +2890,8 @@ init_vbt_panel_defaults(struct intel_panel *panel)
28902890
static void
28912891
init_vbt_missing_defaults(struct drm_i915_private *i915)
28922892
{
2893+
unsigned int ports = DISPLAY_RUNTIME_INFO(i915)->port_mask;
28932894
enum port port;
2894-
int ports = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) |
2895-
BIT(PORT_D) | BIT(PORT_E) | BIT(PORT_F);
28962895

28972896
if (!HAS_DDI(i915) && !IS_CHERRYVIEW(i915))
28982897
return;

0 commit comments

Comments
 (0)