Skip to content

Commit 19d8f31

Browse files
Dillon Varonealexdeucher
authored andcommitted
drm/amd/display: Remove wm_optimized_required
[WHY&HOW] This is a redundant field that is identically to optimized_required, so just replace it. Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by: Dillon Varone <Dillon.Varone@amd.com> Signed-off-by: Ivan Lipski <ivan.lipski@amd.com> Tested-by: Dan Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent c480d07 commit 19d8f31

File tree

5 files changed

+10
-14
lines changed

5 files changed

+10
-14
lines changed

drivers/gpu/drm/amd/display/dc/core/dc.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ bool dc_stream_adjust_vmin_vmax(struct dc *dc,
460460
* avoid conflicting with firmware updates.
461461
*/
462462
if (dc->ctx->dce_version > DCE_VERSION_MAX) {
463-
if ((dc->optimized_required || dc->wm_optimized_required) &&
463+
if (dc->optimized_required &&
464464
(stream->adjust.v_total_max != adjust->v_total_max ||
465465
stream->adjust.v_total_min != adjust->v_total_min)) {
466466
stream->adjust.timing_adjust_pending = true;
@@ -2577,7 +2577,6 @@ void dc_post_update_surfaces_to_stream(struct dc *dc)
25772577
}
25782578

25792579
dc->optimized_required = false;
2580-
dc->wm_optimized_required = false;
25812580
}
25822581

25832582
bool dc_set_generic_gpio_for_stereo(bool enable,
@@ -3056,8 +3055,6 @@ enum surface_update_type dc_check_update_surfaces_for_stream(
30563055
} else if (memcmp(&dc->current_state->bw_ctx.bw.dcn.clk, &dc->clk_mgr->clks, offsetof(struct dc_clocks, prev_p_state_change_support)) != 0) {
30573056
dc->optimized_required = true;
30583057
}
3059-
3060-
dc->optimized_required |= dc->wm_optimized_required;
30613058
}
30623059

30633060
return type;

drivers/gpu/drm/amd/display/dc/dc.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1736,7 +1736,6 @@ struct dc {
17361736

17371737
/* Require to optimize clocks and bandwidth for added/removed planes */
17381738
bool optimized_required;
1739-
bool wm_optimized_required;
17401739
bool idle_optimizations_allowed;
17411740
bool enable_c20_dtm_b0;
17421741

drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3347,7 +3347,7 @@ void dcn10_prepare_bandwidth(
33473347
context,
33483348
false);
33493349

3350-
dc->wm_optimized_required = hubbub->funcs->program_watermarks(hubbub,
3350+
dc->optimized_required = hubbub->funcs->program_watermarks(hubbub,
33513351
&context->bw_ctx.bw.dcn.watermarks,
33523352
dc->res_pool->ref_clocks.dchub_ref_clock_inKhz / 1000,
33533353
true);

drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2390,10 +2390,10 @@ void dcn20_prepare_bandwidth(
23902390
}
23912391

23922392
/* program dchubbub watermarks:
2393-
* For assigning wm_optimized_required, use |= operator since we don't want
2393+
* For assigning optimized_required, use |= operator since we don't want
23942394
* to clear the value if the optimize has not happened yet
23952395
*/
2396-
dc->wm_optimized_required |= hubbub->funcs->program_watermarks(hubbub,
2396+
dc->optimized_required |= hubbub->funcs->program_watermarks(hubbub,
23972397
&context->bw_ctx.bw.dcn.watermarks,
23982398
dc->res_pool->ref_clocks.dchub_ref_clock_inKhz / 1000,
23992399
false);
@@ -2406,10 +2406,10 @@ void dcn20_prepare_bandwidth(
24062406
if (hubbub->funcs->program_compbuf_size) {
24072407
if (context->bw_ctx.dml.ip.min_comp_buffer_size_kbytes) {
24082408
compbuf_size_kb = context->bw_ctx.dml.ip.min_comp_buffer_size_kbytes;
2409-
dc->wm_optimized_required |= (compbuf_size_kb != dc->current_state->bw_ctx.dml.ip.min_comp_buffer_size_kbytes);
2409+
dc->optimized_required |= (compbuf_size_kb != dc->current_state->bw_ctx.dml.ip.min_comp_buffer_size_kbytes);
24102410
} else {
24112411
compbuf_size_kb = context->bw_ctx.bw.dcn.compbuf_size_kb;
2412-
dc->wm_optimized_required |= (compbuf_size_kb != dc->current_state->bw_ctx.bw.dcn.compbuf_size_kb);
2412+
dc->optimized_required |= (compbuf_size_kb != dc->current_state->bw_ctx.bw.dcn.compbuf_size_kb);
24132413
}
24142414

24152415
hubbub->funcs->program_compbuf_size(hubbub, compbuf_size_kb, false);

drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1383,22 +1383,22 @@ void dcn401_prepare_bandwidth(struct dc *dc,
13831383
false);
13841384

13851385
/* program dchubbub watermarks:
1386-
* For assigning wm_optimized_required, use |= operator since we don't want
1386+
* For assigning optimized_required, use |= operator since we don't want
13871387
* to clear the value if the optimize has not happened yet
13881388
*/
1389-
dc->wm_optimized_required |= hubbub->funcs->program_watermarks(hubbub,
1389+
dc->optimized_required |= hubbub->funcs->program_watermarks(hubbub,
13901390
&context->bw_ctx.bw.dcn.watermarks,
13911391
dc->res_pool->ref_clocks.dchub_ref_clock_inKhz / 1000,
13921392
false);
13931393
/* update timeout thresholds */
13941394
if (hubbub->funcs->program_arbiter) {
1395-
dc->wm_optimized_required |= hubbub->funcs->program_arbiter(hubbub, &context->bw_ctx.bw.dcn.arb_regs, false);
1395+
dc->optimized_required |= hubbub->funcs->program_arbiter(hubbub, &context->bw_ctx.bw.dcn.arb_regs, false);
13961396
}
13971397

13981398
/* decrease compbuf size */
13991399
if (hubbub->funcs->program_compbuf_segments) {
14001400
compbuf_size = context->bw_ctx.bw.dcn.arb_regs.compbuf_size;
1401-
dc->wm_optimized_required |= (compbuf_size != dc->current_state->bw_ctx.bw.dcn.arb_regs.compbuf_size);
1401+
dc->optimized_required |= (compbuf_size != dc->current_state->bw_ctx.bw.dcn.arb_regs.compbuf_size);
14021402

14031403
hubbub->funcs->program_compbuf_segments(hubbub, compbuf_size, false);
14041404
}

0 commit comments

Comments
 (0)