Skip to content

Commit 1abd229

Browse files
author
Paul Gortmaker
committed
s390: delete any traces of token ring support
The token ring support is going away from the core kernel. Divorce the S390 drivers from it in advance. Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: linux390@de.ibm.com Cc: linux-s390@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
1 parent e87cc47 commit 1abd229

File tree

5 files changed

+11
-58
lines changed

5 files changed

+11
-58
lines changed

drivers/s390/net/Kconfig

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ menu "S/390 network device drivers"
44
config LCS
55
def_tristate m
66
prompt "Lan Channel Station Interface"
7-
depends on CCW && NETDEVICES && (ETHERNET || TR || FDDI)
7+
depends on CCW && NETDEVICES && (ETHERNET || FDDI)
88
help
99
Select this option if you want to use LCS networking on IBM System z.
10-
This device driver supports Token Ring (IEEE 802.5),
11-
FDDI (IEEE 802.7) and Ethernet.
10+
This device driver supports FDDI (IEEE 802.7) and Ethernet.
1211
To compile as a module, choose M. The module name is lcs.
1312
If you do not know what it is, it's safe to choose Y.
1413

drivers/s390/net/lcs.c

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
#include <linux/if.h>
3131
#include <linux/netdevice.h>
3232
#include <linux/etherdevice.h>
33-
#include <linux/trdevice.h>
3433
#include <linux/fddidevice.h>
3534
#include <linux/inetdevice.h>
3635
#include <linux/in.h>
@@ -50,8 +49,7 @@
5049
#include "lcs.h"
5150

5251

53-
#if !defined(CONFIG_ETHERNET) && \
54-
!defined(CONFIG_TR) && !defined(CONFIG_FDDI)
52+
#if !defined(CONFIG_ETHERNET) && !defined(CONFIG_FDDI)
5553
#error Cannot compile lcs.c without some net devices switched on.
5654
#endif
5755

@@ -1166,10 +1164,7 @@ static void
11661164
lcs_get_mac_for_ipm(__be32 ipm, char *mac, struct net_device *dev)
11671165
{
11681166
LCS_DBF_TEXT(4,trace, "getmac");
1169-
if (dev->type == ARPHRD_IEEE802_TR)
1170-
ip_tr_mc_map(ipm, mac);
1171-
else
1172-
ip_eth_mc_map(ipm, mac);
1167+
ip_eth_mc_map(ipm, mac);
11731168
}
11741169

11751170
/**
@@ -1641,12 +1636,6 @@ lcs_startlan_auto(struct lcs_card *card)
16411636
return 0;
16421637

16431638
#endif
1644-
#ifdef CONFIG_TR
1645-
card->lan_type = LCS_FRAME_TYPE_TR;
1646-
rc = lcs_send_startlan(card, LCS_INITIATOR_TCPIP);
1647-
if (rc == 0)
1648-
return 0;
1649-
#endif
16501639
#ifdef CONFIG_FDDI
16511640
card->lan_type = LCS_FRAME_TYPE_FDDI;
16521641
rc = lcs_send_startlan(card, LCS_INITIATOR_TCPIP);
@@ -2172,12 +2161,6 @@ lcs_new_device(struct ccwgroup_device *ccwgdev)
21722161
dev = alloc_etherdev(0);
21732162
break;
21742163
#endif
2175-
#ifdef CONFIG_TR
2176-
case LCS_FRAME_TYPE_TR:
2177-
card->lan_type_trans = tr_type_trans;
2178-
dev = alloc_trdev(0);
2179-
break;
2180-
#endif
21812164
#ifdef CONFIG_FDDI
21822165
case LCS_FRAME_TYPE_FDDI:
21832166
card->lan_type_trans = fddi_type_trans;

drivers/s390/net/qeth_core.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313

1414
#include <linux/if.h>
1515
#include <linux/if_arp.h>
16-
#include <linux/if_tr.h>
17-
#include <linux/trdevice.h>
1816
#include <linux/etherdevice.h>
1917
#include <linux/if_vlan.h>
2018
#include <linux/ctype.h>

drivers/s390/net/qeth_core_main.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4911,11 +4911,7 @@ struct sk_buff *qeth_core_get_next_skb(struct qeth_card *card,
49114911
break;
49124912
case QETH_HEADER_TYPE_LAYER3:
49134913
skb_len = (*hdr)->hdr.l3.length;
4914-
if ((card->info.link_type == QETH_LINK_TYPE_LANE_TR) ||
4915-
(card->info.link_type == QETH_LINK_TYPE_HSTR))
4916-
headroom = TR_HLEN;
4917-
else
4918-
headroom = ETH_HLEN;
4914+
headroom = ETH_HLEN;
49194915
break;
49204916
case QETH_HEADER_TYPE_OSN:
49214917
skb_len = (*hdr)->hdr.osn.pdu_length;

drivers/s390/net/qeth_l3_main.c

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1671,10 +1671,7 @@ qeth_diags_trace(struct qeth_card *card, enum qeth_diags_trace_cmds diags_cmd)
16711671
static void qeth_l3_get_mac_for_ipm(__u32 ipm, char *mac,
16721672
struct net_device *dev)
16731673
{
1674-
if (dev->type == ARPHRD_IEEE802_TR)
1675-
ip_tr_mc_map(ipm, mac);
1676-
else
1677-
ip_eth_mc_map(ipm, mac);
1674+
ip_eth_mc_map(ipm, mac);
16781675
}
16791676

16801677
static void qeth_l3_add_mc(struct qeth_card *card, struct in_device *in4_dev)
@@ -1922,8 +1919,6 @@ static inline int qeth_l3_rebuild_skb(struct qeth_card *card,
19221919
#endif
19231920
case __constant_htons(ETH_P_IP):
19241921
ip_hdr = (struct iphdr *)skb->data;
1925-
(card->dev->type == ARPHRD_IEEE802_TR) ?
1926-
ip_tr_mc_map(ip_hdr->daddr, tg_addr):
19271922
ip_eth_mc_map(ip_hdr->daddr, tg_addr);
19281923
break;
19291924
default:
@@ -1959,12 +1954,7 @@ static inline int qeth_l3_rebuild_skb(struct qeth_card *card,
19591954
tg_addr, "FAKELL", card->dev->addr_len);
19601955
}
19611956

1962-
#ifdef CONFIG_TR
1963-
if (card->dev->type == ARPHRD_IEEE802_TR)
1964-
skb->protocol = tr_type_trans(skb, card->dev);
1965-
else
1966-
#endif
1967-
skb->protocol = eth_type_trans(skb, card->dev);
1957+
skb->protocol = eth_type_trans(skb, card->dev);
19681958

19691959
if (hdr->hdr.l3.ext_flags &
19701960
(QETH_HDR_EXT_VLAN_FRAME | QETH_HDR_EXT_INCLUDE_VLAN_TAG)) {
@@ -2883,13 +2873,7 @@ static void qeth_l3_fill_header(struct qeth_card *card, struct qeth_hdr *hdr,
28832873
hdr->hdr.l3.flags &= ~QETH_HDR_PASSTHRU;
28842874
memcpy(hdr->hdr.l3.dest_addr, pkey, 16);
28852875
} else {
2886-
/* passthrough */
2887-
if ((skb->dev->type == ARPHRD_IEEE802_TR) &&
2888-
!memcmp(skb->data + sizeof(struct qeth_hdr) +
2889-
sizeof(__u16), skb->dev->broadcast, 6)) {
2890-
hdr->hdr.l3.flags = QETH_CAST_BROADCAST |
2891-
QETH_HDR_PASSTHRU;
2892-
} else if (!memcmp(skb->data + sizeof(struct qeth_hdr),
2876+
if (!memcmp(skb->data + sizeof(struct qeth_hdr),
28932877
skb->dev->broadcast, 6)) {
28942878
/* broadcast? */
28952879
hdr->hdr.l3.flags = QETH_CAST_BROADCAST |
@@ -3031,10 +3015,7 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
30313015
skb_pull(new_skb, ETH_HLEN);
30323016
} else {
30333017
if (ipv == 4) {
3034-
if (card->dev->type == ARPHRD_IEEE802_TR)
3035-
skb_pull(new_skb, TR_HLEN);
3036-
else
3037-
skb_pull(new_skb, ETH_HLEN);
3018+
skb_pull(new_skb, ETH_HLEN);
30383019
}
30393020

30403021
if (ipv != 4 && vlan_tx_tag_present(new_skb)) {
@@ -3318,12 +3299,8 @@ static int qeth_l3_setup_netdev(struct qeth_card *card)
33183299
card->info.type == QETH_CARD_TYPE_OSX) {
33193300
if ((card->info.link_type == QETH_LINK_TYPE_LANE_TR) ||
33203301
(card->info.link_type == QETH_LINK_TYPE_HSTR)) {
3321-
#ifdef CONFIG_TR
3322-
card->dev = alloc_trdev(0);
3323-
#endif
3324-
if (!card->dev)
3325-
return -ENODEV;
3326-
card->dev->netdev_ops = &qeth_l3_netdev_ops;
3302+
pr_info("qeth_l3: ignoring TR device\n");
3303+
return -ENODEV;
33273304
} else {
33283305
card->dev = alloc_etherdev(0);
33293306
if (!card->dev)

0 commit comments

Comments
 (0)