Skip to content

Commit 1b304c0

Browse files
WangYulikeithbusch
authored andcommitted
nvmet-fc: Remove unused functions
The functions nvmet_fc_iodnum() and nvmet_fc_fodnum() are currently unutilized. Following commit c534320 ("nvme-fabrics: Add target support for FC transport"), which introduced these two functions, they have not been used at all in practice. Remove them to resolve the compiler warnings. Fix follow errors with clang-19 when W=1e: drivers/nvme/target/fc.c:177:1: error: unused function 'nvmet_fc_iodnum' [-Werror,-Wunused-function] 177 | nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr) | ^~~~~~~~~~~~~~~ drivers/nvme/target/fc.c:183:1: error: unused function 'nvmet_fc_fodnum' [-Werror,-Wunused-function] 183 | nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr) | ^~~~~~~~~~~~~~~ 2 errors generated. make[8]: *** [scripts/Makefile.build:207: drivers/nvme/target/fc.o] Error 1 make[7]: *** [scripts/Makefile.build:465: drivers/nvme/target] Error 2 make[6]: *** [scripts/Makefile.build:465: drivers/nvme] Error 2 make[6]: *** Waiting for unfinished jobs.... Fixes: c534320 ("nvme-fabrics: Add target support for FC transport") Signed-off-by: WangYuli <wangyuli@uniontech.com> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Keith Busch <kbusch@kernel.org>
1 parent f1b47ae commit 1b304c0

File tree

1 file changed

+0
-14
lines changed
  • drivers/nvme/target

1 file changed

+0
-14
lines changed

drivers/nvme/target/fc.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -172,20 +172,6 @@ struct nvmet_fc_tgt_assoc {
172172
struct work_struct del_work;
173173
};
174174

175-
176-
static inline int
177-
nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr)
178-
{
179-
return (iodptr - iodptr->tgtport->iod);
180-
}
181-
182-
static inline int
183-
nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr)
184-
{
185-
return (fodptr - fodptr->queue->fod);
186-
}
187-
188-
189175
/*
190176
* Association and Connection IDs:
191177
*

0 commit comments

Comments
 (0)