Skip to content

Commit 1d23a56

Browse files
Alex Elderkuba-moo
authored andcommitted
net: ipa: set error code in gsi_channel_setup()
In gsi_channel_setup(), we check to see if the configuration data contains any information about channels that are not supported by the hardware. If one is found, we abort the setup process, but the error code (ret) is not set in this case. Fix this bug. Fixes: 650d160 ("soc: qcom: ipa: the generic software interface") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alex Elder <elder@linaro.org> Link: https://lore.kernel.org/r/20210204010655.15619-1-elder@linaro.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 81b8be6 commit 1d23a56

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/ipa/gsi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1710,6 +1710,7 @@ static int gsi_channel_setup(struct gsi *gsi)
17101710
if (!channel->gsi)
17111711
continue; /* Ignore uninitialized channels */
17121712

1713+
ret = -EINVAL;
17131714
dev_err(gsi->dev, "channel %u not supported by hardware\n",
17141715
channel_id - 1);
17151716
channel_id = gsi->channel_count;

0 commit comments

Comments
 (0)