net: mvneta: use phylink_pcs_change() to report PCS link change events

Russell King (Oracle) · kuba-moo · commit 21c8e45acbdb · 2024-04-29T19:04:23.000-07:00
Use phylink_pcs_change() when reporting changes in PCS link state to phylink as the interrupts are informing us about changes to the PCS state. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/E1s0OGs-009hgl-Jg@rmk-PC.armlinux.org.uk Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
@@ -3259,7 +3259,8 @@ static void mvneta_link_change(struct mvneta_port *pp)
 {
 	u32 gmac_stat = mvreg_read(pp, MVNETA_GMAC_STATUS);
 
-	phylink_mac_change(pp->phylink, !!(gmac_stat & MVNETA_GMAC_LINK_UP));
+	phylink_pcs_change(&pp->phylink_pcs,
+			   !!(gmac_stat & MVNETA_GMAC_LINK_UP));
 }
 
 /* NAPI handler

Original file line number	Diff line number	Diff line change
`@@ -3259,7 +3259,8 @@ static void mvneta_link_change(struct mvneta_port *pp)`
`3259`	`3259`	`{`
`3260`	`3260`	`u32 gmac_stat = mvreg_read(pp, MVNETA_GMAC_STATUS);`
`3261`	`3261`
`3262`		`- phylink_mac_change(pp->phylink, !!(gmac_stat & MVNETA_GMAC_LINK_UP));`
	`3262`	`+ phylink_pcs_change(&pp->phylink_pcs,`
	`3263`	`+ !!(gmac_stat & MVNETA_GMAC_LINK_UP));`
`3263`	`3264`	`}`
`3264`	`3265`
`3265`	`3266`	`/* NAPI handler`