Skip to content

Commit 23ef388

Browse files
charliu-AMDENGalexdeucher
authored andcommitted
drm/amd/display: fix dcn4x init failed
[why] failed due to cmdtable not created. switch atombios cmdtable as default. Reviewed-by: Alvin Lee <alvin.lee2@amd.com> Signed-off-by: Charlene Liu <Charlene.Liu@amd.com> Signed-off-by: Zaeem Mohamed <zaeem.mohamed@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent ba93ddd commit 23ef388

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

drivers/gpu/drm/amd/display/dc/bios/command_table2.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ static void init_dig_encoder_control(struct bios_parser *bp)
101101
bp->cmd_tbl.dig_encoder_control = encoder_control_digx_v1_5;
102102
break;
103103
default:
104-
dm_output_to_console("Don't have dig_encoder_control for v%d\n", version);
105104
bp->cmd_tbl.dig_encoder_control = encoder_control_fallback;
106105
break;
107106
}
@@ -239,7 +238,6 @@ static void init_transmitter_control(struct bios_parser *bp)
239238
bp->cmd_tbl.transmitter_control = transmitter_control_v1_7;
240239
break;
241240
default:
242-
dm_output_to_console("Don't have transmitter_control for v%d\n", crev);
243241
bp->cmd_tbl.transmitter_control = transmitter_control_fallback;
244242
break;
245243
}
@@ -454,8 +452,6 @@ static void init_set_pixel_clock(struct bios_parser *bp)
454452
bp->cmd_tbl.set_pixel_clock = set_pixel_clock_v7;
455453
break;
456454
default:
457-
dm_output_to_console("Don't have set_pixel_clock for v%d\n",
458-
BIOS_CMD_TABLE_PARA_REVISION(setpixelclock));
459455
bp->cmd_tbl.set_pixel_clock = set_pixel_clock_fallback;
460456
break;
461457
}
@@ -600,7 +596,6 @@ static void init_set_crtc_timing(struct bios_parser *bp)
600596
set_crtc_using_dtd_timing_v3;
601597
break;
602598
default:
603-
dm_output_to_console("Don't have set_crtc_timing for v%d\n", dtd_version);
604599
bp->cmd_tbl.set_crtc_timing = NULL;
605600
break;
606601
}
@@ -717,8 +712,6 @@ static void init_enable_crtc(struct bios_parser *bp)
717712
bp->cmd_tbl.enable_crtc = enable_crtc_v1;
718713
break;
719714
default:
720-
dm_output_to_console("Don't have enable_crtc for v%d\n",
721-
BIOS_CMD_TABLE_PARA_REVISION(enablecrtc));
722715
bp->cmd_tbl.enable_crtc = NULL;
723716
break;
724717
}
@@ -910,8 +903,6 @@ static void init_set_dce_clock(struct bios_parser *bp)
910903
bp->cmd_tbl.set_dce_clock = set_dce_clock_v2_1;
911904
break;
912905
default:
913-
dm_output_to_console("Don't have set_dce_clock for v%d\n",
914-
BIOS_CMD_TABLE_PARA_REVISION(setdceclock));
915906
bp->cmd_tbl.set_dce_clock = NULL;
916907
break;
917908
}

drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@ bool dal_bios_parser_init_cmd_tbl_helper2(
8888
return true;
8989

9090
default:
91-
/* Unsupported DCE */
92-
BREAK_TO_DEBUGGER();
91+
*h = dal_cmd_tbl_helper_dce112_get_table2();
9392
return false;
9493
}
9594
}

0 commit comments

Comments
 (0)