Skip to content

Commit 253e9b4

Browse files
Volodymyr Mytnykdavem330
authored andcommitted
net: marvell: prestera: fix brige port operation
Return NOTIFY_DONE (dont't care) for switchdev notifications that prestera driver don't know how to handle them. With introduction of SWITCHDEV_BRPORT_[UN]OFFLOADED switchdev events, the driver rejects adding swport to bridge operation which is handled by prestera_bridge_port_join() func. The root cause of this is that prestera driver returns error (EOPNOTSUPP) in prestera_switchdev_blk_event() handler for unknown swdev events. This causes switchdev_bridge_port_offload() to fail when adding port to bridge in prestera_bridge_port_join(). Fixes: 957e223 ("net: make switchdev_bridge_port_{,unoffload} loosely coupled with the bridge") Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d6821c5 commit 253e9b4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/marvell/prestera/prestera_switchdev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1124,7 +1124,7 @@ static int prestera_switchdev_blk_event(struct notifier_block *unused,
11241124
prestera_port_obj_attr_set);
11251125
break;
11261126
default:
1127-
err = -EOPNOTSUPP;
1127+
return NOTIFY_DONE;
11281128
}
11291129

11301130
return notifier_from_errno(err);

0 commit comments

Comments
 (0)