Skip to content

Commit 292145a

Browse files
legoatermpe
authored andcommitted
powerpc/xive: Remove irqd_is_started() check when setting the affinity
In the early days of XIVE support, commit cffb717 ("powerpc/xive: Ensure active irqd when setting affinity") tried to fix an issue related to interrupt migration. If the root cause was related to CPU unplug, it should have been fixed and there is no reason to keep the irqd_is_started() check. This test is also breaking affinity setting of MSIs which can set before starting the associated IRQ. Signed-off-by: Cédric Le Goater <clg@kaod.org> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20210701132750.1475580-8-clg@kaod.org
1 parent 5690bca commit 292145a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

arch/powerpc/sysdev/xive/common.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -709,10 +709,6 @@ static int xive_irq_set_affinity(struct irq_data *d,
709709
if (cpumask_any_and(cpumask, cpu_online_mask) >= nr_cpu_ids)
710710
return -EINVAL;
711711

712-
/* Don't do anything if the interrupt isn't started */
713-
if (!irqd_is_started(d))
714-
return IRQ_SET_MASK_OK;
715-
716712
/*
717713
* If existing target is already in the new mask, and is
718714
* online then do nothing.

0 commit comments

Comments
 (0)