Skip to content

Commit 2a22bea

Browse files
nehebkuba-moo
authored andcommitted
net: mtk_eth_soc: use ethtool_puts
Allows simplifying get_strings and avoids manual pointer manipulation. Tested on Belkin RT1800. Signed-off-by: Rosen Penev <rosenp@gmail.com> Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com> Link: https://patch.msgid.link/20241011200225.7403-1-rosenp@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9de722c commit 2a22bea

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/net/ethernet/mediatek/mtk_eth_soc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4329,10 +4329,8 @@ static void mtk_get_strings(struct net_device *dev, u32 stringset, u8 *data)
43294329
case ETH_SS_STATS: {
43304330
struct mtk_mac *mac = netdev_priv(dev);
43314331

4332-
for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++) {
4333-
memcpy(data, mtk_ethtool_stats[i].str, ETH_GSTRING_LEN);
4334-
data += ETH_GSTRING_LEN;
4335-
}
4332+
for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++)
4333+
ethtool_puts(&data, mtk_ethtool_stats[i].str);
43364334
if (mtk_page_pool_enabled(mac->hw))
43374335
page_pool_ethtool_stats_get_strings(data);
43384336
break;

0 commit comments

Comments
 (0)