Commit 2a3e89a
ice: register devlink prior to creating health reporters
ice_health_init() was introduced in the commit 2a82874 ("ice: add
Tx hang devlink health reporter"). The call to it should have been put
after ice_devlink_register(). It went unnoticed until next reporter by
Konrad, which receives events from FW. FW is reporting all events, also
from prior driver load, and thus it is not unlikely to have something
at the very beginning. And that results in a splat:
[ 24.455950] ? devlink_recover_notify.constprop.0+0x198/0x1b0
[ 24.455973] devlink_health_report+0x5d/0x2a0
[ 24.455976] ? __pfx_ice_health_status_lookup_compare+0x10/0x10 [ice]
[ 24.456044] ice_process_health_status_event+0x1b7/0x200 [ice]
Do the analogous thing for deinit patch.
Fixes: 85d6164 ("ice: add fw and port health reporters")
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Konrad Knitter <konrad.knitter@intel.com>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>1 parent dce97cb commit 2a3e89a
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5065 | 5065 | | |
5066 | 5066 | | |
5067 | 5067 | | |
5068 | | - | |
5069 | 5068 | | |
| 5069 | + | |
5070 | 5070 | | |
5071 | 5071 | | |
5072 | 5072 | | |
5073 | 5073 | | |
5074 | 5074 | | |
5075 | 5075 | | |
5076 | | - | |
5077 | 5076 | | |
| 5077 | + | |
5078 | 5078 | | |
5079 | 5079 | | |
5080 | 5080 | | |
| |||
0 commit comments