spi: spi-pci1xxxx: Fix error code in probe

Dan Carpenter · broonie · commit 2b74aea6d078 · 2025-06-08T23:30:05.000+01:00
Return the error code if pci_alloc_irq_vectors() fails. Don't return success. Fixes: b4608e9 ("spi: spi-pci1xxxx: Fix Probe failure with Dual SPI instance with INTx interrupts") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Thangaraj Samynathan <thangaraj.s@microchip.com> Link: https://patch.msgid.link/aEKvDrUxD19GWi0u@stanley.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/spi/spi-pci1xxxx.c b/drivers/spi/spi-pci1xxxx.c
@@ -765,7 +765,7 @@ static int pci1xxxx_spi_probe(struct pci_dev *pdev, const struct pci_device_id *
 							   PCI_IRQ_ALL_TYPES);
 			if (num_vector < 0) {
 				dev_err(&pdev->dev, "Error allocating MSI vectors\n");
-				return ret;
+				return num_vector;
 			}
 
 			init_completion(&spi_sub_ptr->spi_xfer_done);

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,7 @@ static int pci1xxxx_spi_probe(struct pci_dev pdev, const struct pci_device_id `
`765`	`765`	`PCI_IRQ_ALL_TYPES);`
`766`	`766`	`if (num_vector < 0) {`
`767`	`767`	`dev_err(&pdev->dev, "Error allocating MSI vectors\n");`
`768`		`- return ret;`
	`768`	`+ return num_vector;`
`769`	`769`	`}`
`770`	`770`
`771`	`771`	`init_completion(&spi_sub_ptr->spi_xfer_done);`