Skip to content

Commit 2c4d376

Browse files
pavanchebbiPaolo Abeni
authored andcommitted
bnxt_en: Add devlink support for ENABLE_ROCE nvm parameter
Add set/show support for the ENABLE_ROCE NVM parameter to enable/disable RoCE for a PF. Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com> Co-developed-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Link: https://patch.msgid.link/20250310183129.3154117-4-michael.chan@broadcom.com Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent ed82740 commit 2c4d376

File tree

3 files changed

+36
-0
lines changed

3 files changed

+36
-0
lines changed

Documentation/networking/devlink/bnxt.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ Parameters
2424
- Permanent
2525
* - ``enable_remote_dev_reset``
2626
- Runtime
27+
* - ``enable_roce``
28+
- Permanent
2729

2830
The ``bnxt`` driver also implements the following driver-specific
2931
parameters.

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -679,6 +679,8 @@ static const struct bnxt_dl_nvm_param nvm_params[] = {
679679
NVM_OFF_MSIX_VEC_PER_PF_MAX, BNXT_NVM_SHARED_CFG, 10, 4},
680680
{DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN,
681681
NVM_OFF_MSIX_VEC_PER_PF_MIN, BNXT_NVM_SHARED_CFG, 7, 4},
682+
{DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE, NVM_OFF_SUPPORT_RDMA,
683+
BNXT_NVM_FUNC_CFG, 1, 1},
682684
{BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK, NVM_OFF_DIS_GRE_VER_CHECK,
683685
BNXT_NVM_SHARED_CFG, 1, 1},
684686
};
@@ -1132,6 +1134,32 @@ static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
11321134
return bnxt_hwrm_nvm_req(bp, id, req, &ctx->val);
11331135
}
11341136

1137+
static int bnxt_dl_roce_validate(struct devlink *dl, u32 id,
1138+
union devlink_param_value val,
1139+
struct netlink_ext_ack *extack)
1140+
{
1141+
const struct bnxt_dl_nvm_param nvm_roce_cap = {0, NVM_OFF_RDMA_CAPABLE,
1142+
BNXT_NVM_SHARED_CFG, 1, 1};
1143+
struct bnxt *bp = bnxt_get_bp_from_dl(dl);
1144+
struct hwrm_nvm_get_variable_input *req;
1145+
union devlink_param_value roce_cap;
1146+
int rc;
1147+
1148+
rc = hwrm_req_init(bp, req, HWRM_NVM_GET_VARIABLE);
1149+
if (rc)
1150+
return rc;
1151+
1152+
if (__bnxt_hwrm_nvm_req(bp, &nvm_roce_cap, req, &roce_cap)) {
1153+
NL_SET_ERR_MSG_MOD(extack, "Unable to verify if device is RDMA Capable");
1154+
return -EINVAL;
1155+
}
1156+
if (!roce_cap.vbool) {
1157+
NL_SET_ERR_MSG_MOD(extack, "Device does not support RDMA");
1158+
return -EINVAL;
1159+
}
1160+
return 0;
1161+
}
1162+
11351163
static int bnxt_dl_msix_validate(struct devlink *dl, u32 id,
11361164
union devlink_param_value val,
11371165
struct netlink_ext_ack *extack)
@@ -1196,6 +1224,10 @@ static const struct devlink_param bnxt_dl_params[] = {
11961224
BIT(DEVLINK_PARAM_CMODE_PERMANENT),
11971225
bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
11981226
bnxt_dl_msix_validate),
1227+
DEVLINK_PARAM_GENERIC(ENABLE_ROCE,
1228+
BIT(DEVLINK_PARAM_CMODE_PERMANENT),
1229+
bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
1230+
bnxt_dl_roce_validate),
11991231
DEVLINK_PARAM_DRIVER(BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK,
12001232
"gre_ver_check", DEVLINK_PARAM_TYPE_BOOL,
12011233
BIT(DEVLINK_PARAM_CMODE_PERMANENT),

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,10 @@ static inline void bnxt_dl_set_remote_reset(struct devlink *dl, bool value)
4141
#define NVM_OFF_MSIX_VEC_PER_PF_MAX 108
4242
#define NVM_OFF_MSIX_VEC_PER_PF_MIN 114
4343
#define NVM_OFF_IGNORE_ARI 164
44+
#define NVM_OFF_RDMA_CAPABLE 161
4445
#define NVM_OFF_DIS_GRE_VER_CHECK 171
4546
#define NVM_OFF_ENABLE_SRIOV 401
47+
#define NVM_OFF_SUPPORT_RDMA 506
4648
#define NVM_OFF_NVM_CFG_VER 602
4749

4850
#define BNXT_NVM_CFG_VER_BITS 8

0 commit comments

Comments
 (0)