Skip to content

Commit 2d29058

Browse files
LorenzoBianconinbd168
authored andcommitted
wifi: mt76: mt7603: rely on shared poll_list field
Rely on poll_list field in mt76_wcid structure and get rid of private copy. Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Felix Fietkau <nbd@nbd.name>
1 parent b73e1d9 commit 2d29058

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

drivers/net/wireless/mediatek/mt76/mt7603/mac.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -419,8 +419,8 @@ void mt7603_mac_sta_poll(struct mt7603_dev *dev)
419419
}
420420

421421
msta = list_first_entry(&dev->mt76.sta_poll_list,
422-
struct mt7603_sta, poll_list);
423-
list_del_init(&msta->poll_list);
422+
struct mt7603_sta, wcid.poll_list);
423+
list_del_init(&msta->wcid.poll_list);
424424
spin_unlock_bh(&dev->mt76.sta_poll_lock);
425425

426426
addr = mt7603_wtbl4_addr(msta->wcid.idx);
@@ -1267,9 +1267,9 @@ void mt7603_mac_add_txs(struct mt7603_dev *dev, void *data)
12671267
msta = container_of(wcid, struct mt7603_sta, wcid);
12681268
sta = wcid_to_sta(wcid);
12691269

1270-
if (list_empty(&msta->poll_list)) {
1270+
if (list_empty(&msta->wcid.poll_list)) {
12711271
spin_lock_bh(&dev->mt76.sta_poll_lock);
1272-
list_add_tail(&msta->poll_list, &dev->mt76.sta_poll_list);
1272+
list_add_tail(&msta->wcid.poll_list, &dev->mt76.sta_poll_list);
12731273
spin_unlock_bh(&dev->mt76.sta_poll_lock);
12741274
}
12751275

drivers/net/wireless/mediatek/mt76/mt7603/main.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ mt7603_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
6666

6767
idx = MT7603_WTBL_RESERVED - 1 - mvif->idx;
6868
dev->mt76.vif_mask |= BIT_ULL(mvif->idx);
69-
INIT_LIST_HEAD(&mvif->sta.poll_list);
69+
INIT_LIST_HEAD(&mvif->sta.wcid.poll_list);
7070
mvif->sta.wcid.idx = idx;
7171
mvif->sta.wcid.hw_key_idx = -1;
7272
mt76_packet_id_init(&mvif->sta.wcid);
@@ -101,8 +101,8 @@ mt7603_remove_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
101101
rcu_assign_pointer(dev->mt76.wcid[idx], NULL);
102102

103103
spin_lock_bh(&dev->mt76.sta_poll_lock);
104-
if (!list_empty(&msta->poll_list))
105-
list_del_init(&msta->poll_list);
104+
if (!list_empty(&msta->wcid.poll_list))
105+
list_del_init(&msta->wcid.poll_list);
106106
spin_unlock_bh(&dev->mt76.sta_poll_lock);
107107

108108
mutex_lock(&dev->mt76.mutex);
@@ -351,7 +351,7 @@ mt7603_sta_add(struct mt76_dev *mdev, struct ieee80211_vif *vif,
351351
if (idx < 0)
352352
return -ENOSPC;
353353

354-
INIT_LIST_HEAD(&msta->poll_list);
354+
INIT_LIST_HEAD(&msta->wcid.poll_list);
355355
__skb_queue_head_init(&msta->psq);
356356
msta->ps = ~0;
357357
msta->smps = ~0;
@@ -389,8 +389,8 @@ mt7603_sta_remove(struct mt76_dev *mdev, struct ieee80211_vif *vif,
389389
spin_unlock_bh(&dev->ps_lock);
390390

391391
spin_lock_bh(&mdev->sta_poll_lock);
392-
if (!list_empty(&msta->poll_list))
393-
list_del_init(&msta->poll_list);
392+
if (!list_empty(&msta->wcid.poll_list))
393+
list_del_init(&msta->wcid.poll_list);
394394
spin_unlock_bh(&mdev->sta_poll_lock);
395395

396396
mt7603_wtbl_clear(dev, wcid->idx);

drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ struct mt7603_sta {
6464

6565
struct mt7603_vif *vif;
6666

67-
struct list_head poll_list;
6867
u32 tx_airtime_ac[4];
6968

7069
struct sk_buff_head psq;

0 commit comments

Comments
 (0)