net/mlx5e: Fix mlx5e_tx_reporter_create return value

Eran Ben Elisha · Saeed Mahameed · commit 2e5b0534622f · 2019-02-22T13:38:24.000-08:00
If reporter is ERR_PTR or NULL, error code shall be returned. At all other cases it shall return success. Fix that. Fixes: de8650a ("net/mlx5e: Add tx reporter support") Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c
@@ -297,7 +297,7 @@ int mlx5e_tx_reporter_create(struct mlx5e_priv *priv)
 		netdev_warn(priv->netdev,
 			    "Failed to create tx reporter, err = %ld\n",
 			    PTR_ERR(priv->tx_reporter));
-	return PTR_ERR_OR_ZERO(priv->tx_reporter);
+	return IS_ERR_OR_NULL(priv->tx_reporter);
 }
 
 void mlx5e_tx_reporter_destroy(struct mlx5e_priv *priv)

Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ int mlx5e_tx_reporter_create(struct mlx5e_priv *priv)`
`297`	`297`	`netdev_warn(priv->netdev,`
`298`	`298`	`"Failed to create tx reporter, err = %ld\n",`
`299`	`299`	`PTR_ERR(priv->tx_reporter));`
`300`		`- return PTR_ERR_OR_ZERO(priv->tx_reporter);`
	`300`	`+ return IS_ERR_OR_NULL(priv->tx_reporter);`
`301`	`301`	`}`
`302`	`302`
`303`	`303`	`void mlx5e_tx_reporter_destroy(struct mlx5e_priv *priv)`