vxlan: check rtnl_configure_link return code correctly

Fabian Frederick · davem330 · commit 2eabcb8afe74 · 2020-09-25T16:58:07.000-07:00
rtnl_configure_link is always checked if &lt; 0 for error code.

Signed-off-by: Fabian Frederick &lt;fabf@skynet.be&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
@@ -3890,7 +3890,7 @@ static int __vxlan_dev_create(struct net *net, struct net_device *dev,
 	}
 
 	err = rtnl_configure_link(dev, NULL);
-	if (err)
+	if (err < 0)
 		goto unlink;
 
 	if (f) {

Original file line number	Diff line number	Diff line change
`@@ -3890,7 +3890,7 @@ static int __vxlan_dev_create(struct net net, struct net_device dev,`
`3890`	`3890`	`}`
`3891`	`3891`
`3892`	`3892`	`err = rtnl_configure_link(dev, NULL);`
`3893`		`- if (err)`
	`3893`	`+ if (err < 0)`
`3894`	`3894`	`goto unlink;`
`3895`	`3895`
`3896`	`3896`	`if (f) {`