Skip to content

Commit 2f7a26a

Browse files
xp4ns3tiwai
authored andcommitted
ALSA: pcm: Test for "silence" field in struct "pcm_format_data"
Syzbot reports "KASAN: null-ptr-deref Write in snd_pcm_format_set_silence".[1] It is due to missing validation of the "silence" field of struct "pcm_format_data" in "pcm_formats" array. Add a test for valid "pat" and, if it is not so, return -EINVAL. [1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/ Reported-and-tested-by: syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20220409012655.9399-1-fmdefrancesco@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent fee2ec8 commit 2f7a26a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/core/pcm_misc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ int snd_pcm_format_set_silence(snd_pcm_format_t format, void *data, unsigned int
433433
return 0;
434434
width = pcm_formats[(INT)format].phys; /* physical width */
435435
pat = pcm_formats[(INT)format].silence;
436-
if (! width)
436+
if (!width || !pat)
437437
return -EINVAL;
438438
/* signed or 1 byte data */
439439
if (pcm_formats[(INT)format].signd == 1 || width <= 8) {

0 commit comments

Comments
 (0)