net: phy: microchip: lan87xx: reinit PHY after cable test

olerem · kuba-moo · commit 30f747b8d53b · 2024-07-08T20:22:13.000-07:00
Reinit PHY after cable test, otherwise link can't be established on tested port. This issue is reproducible on LAN9372 switches with integrated 100BaseT1 PHYs. Fixes: 7880502 ("net: phy: microchip_t1: add cable test support for lan87xx phy") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20240705084954.83048-1-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
@@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev)
 	ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A,
 				lan87xx_cable_test_report_trans(detect));
 
-	return 0;
+	return phy_init_hw(phydev);
 }
 
 static int lan87xx_cable_test_get_status(struct phy_device *phydev,

Original file line number	Diff line number	Diff line change
`@@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev)`
`748`	`748`	`ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A,`
`749`	`749`	`lan87xx_cable_test_report_trans(detect));`
`750`	`750`
`751`		`- return 0;`
	`751`	`+ return phy_init_hw(phydev);`
`752`	`752`	`}`
`753`	`753`
`754`	`754`	`static int lan87xx_cable_test_get_status(struct phy_device *phydev,`