[SCSI] qla4xxx: Return error if minidump data collection fails

Vikas Chaudhary · James Bottomley · commit 35a9c2ab3914 · 2013-09-03T07:27:57.000-07:00
Return error from function qla4_8xxx_collect_md_data()
if minidump data collection fails.

Signed-off-by: Vikas Chaudhary &lt;vikas.chaudhary@qlogic.com&gt;
Signed-off-by: James Bottomley &lt;JBottomley@Parallels.com&gt;
diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
@@ -2765,6 +2765,7 @@ static int qla4_8xxx_collect_md_data(struct scsi_qla_host *ha)
 		ql4_printk(KERN_INFO, ha,
 			   "Dump data mismatch: Data collected: [0x%x], total_data_size:[0x%x]\n",
 			   data_collected, ha->fw_dump_size);
+		rval = QLA_ERROR;
 		goto md_failed;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2765,6 +2765,7 @@ static int qla4_8xxx_collect_md_data(struct scsi_qla_host *ha)`
`2765`	`2765`	`ql4_printk(KERN_INFO, ha,`
`2766`	`2766`	`"Dump data mismatch: Data collected: [0x%x], total_data_size:[0x%x]\n",`
`2767`	`2767`	`data_collected, ha->fw_dump_size);`
	`2768`	`+ rval = QLA_ERROR;`
`2768`	`2769`	`goto md_failed;`
`2769`	`2770`	`}`
`2770`	`2771`