Skip to content

Commit 36f7004

Browse files
Tero Kristoij-intel
authored andcommitted
platform/x86/intel-uncore-freq: Re-arrange bit masks
Rename the various bitmasks from the 'UNCORE_GENMASK_*' to 'UNCORE_*_MASK', and re-order them based on the register they reside in. No functional change intended. Signed-off-by: Tero Kristo <tero.kristo@linux.intel.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Link: https://lore.kernel.org/r/20240617060708.892981-2-tero.kristo@linux.intel.com Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent fe899f8 commit 36f7004

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,12 @@ struct tpmi_uncore_struct {
6969
bool write_blocked;
7070
};
7171

72-
#define UNCORE_GENMASK_MIN_RATIO GENMASK_ULL(21, 15)
73-
#define UNCORE_GENMASK_MAX_RATIO GENMASK_ULL(14, 8)
74-
#define UNCORE_GENMASK_CURRENT_RATIO GENMASK_ULL(6, 0)
72+
/* Bit definitions for STATUS register */
73+
#define UNCORE_CURRENT_RATIO_MASK GENMASK_ULL(6, 0)
74+
75+
/* Bit definitions for CONTROL register */
76+
#define UNCORE_MAX_RATIO_MASK GENMASK_ULL(14, 8)
77+
#define UNCORE_MIN_RATIO_MASK GENMASK_ULL(21, 15)
7578

7679
/* Helper function to read MMIO offset for max/min control frequency */
7780
static void read_control_freq(struct tpmi_uncore_cluster_info *cluster_info,
@@ -80,11 +83,11 @@ static void read_control_freq(struct tpmi_uncore_cluster_info *cluster_info,
8083
u64 control;
8184

8285
control = readq(cluster_info->cluster_base + UNCORE_CONTROL_INDEX);
83-
*max = FIELD_GET(UNCORE_GENMASK_MAX_RATIO, control) * UNCORE_FREQ_KHZ_MULTIPLIER;
84-
*min = FIELD_GET(UNCORE_GENMASK_MIN_RATIO, control) * UNCORE_FREQ_KHZ_MULTIPLIER;
86+
*max = FIELD_GET(UNCORE_MAX_RATIO_MASK, control) * UNCORE_FREQ_KHZ_MULTIPLIER;
87+
*min = FIELD_GET(UNCORE_MIN_RATIO_MASK, control) * UNCORE_FREQ_KHZ_MULTIPLIER;
8588
}
8689

87-
#define UNCORE_MAX_RATIO FIELD_MAX(UNCORE_GENMASK_MAX_RATIO)
90+
#define UNCORE_MAX_RATIO FIELD_MAX(UNCORE_MAX_RATIO_MASK)
8891

8992
/* Callback for sysfs read for max/min frequencies. Called under mutex locks */
9093
static int uncore_read_control_freq(struct uncore_data *data, unsigned int *min,
@@ -134,11 +137,11 @@ static void write_control_freq(struct tpmi_uncore_cluster_info *cluster_info, un
134137
control = readq(cluster_info->cluster_base + UNCORE_CONTROL_INDEX);
135138

136139
if (min_max) {
137-
control &= ~UNCORE_GENMASK_MAX_RATIO;
138-
control |= FIELD_PREP(UNCORE_GENMASK_MAX_RATIO, input);
140+
control &= ~UNCORE_MAX_RATIO_MASK;
141+
control |= FIELD_PREP(UNCORE_MAX_RATIO_MASK, input);
139142
} else {
140-
control &= ~UNCORE_GENMASK_MIN_RATIO;
141-
control |= FIELD_PREP(UNCORE_GENMASK_MIN_RATIO, input);
143+
control &= ~UNCORE_MIN_RATIO_MASK;
144+
control |= FIELD_PREP(UNCORE_MIN_RATIO_MASK, input);
142145
}
143146

144147
writeq(control, (cluster_info->cluster_base + UNCORE_CONTROL_INDEX));
@@ -204,7 +207,7 @@ static int uncore_read_freq(struct uncore_data *data, unsigned int *freq)
204207
return -ENODATA;
205208

206209
status = readq((u8 __iomem *)cluster_info->cluster_base + UNCORE_STATUS_INDEX);
207-
*freq = FIELD_GET(UNCORE_GENMASK_CURRENT_RATIO, status) * UNCORE_FREQ_KHZ_MULTIPLIER;
210+
*freq = FIELD_GET(UNCORE_CURRENT_RATIO_MASK, status) * UNCORE_FREQ_KHZ_MULTIPLIER;
208211

209212
return 0;
210213
}

0 commit comments

Comments
 (0)