Skip to content

Commit 388d333

Browse files
natgurumoorthydavem330
authored andcommitted
tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0
The new tg3 driver leaves REG_BASE_ADDR (PCI config offset 120) uninitialized. From power on reset this register may have garbage in it. The Register Base Address register defines the device local address of a register. The data pointed to by this location is read or written using the Register Data register (PCI config offset 128). When REG_BASE_ADDR has garbage any read or write of Register Data Register (PCI 128) will cause the PCI bus to lock up. The TCO watchdog will fire and bring down the system. Signed-off-by: Nat Gurumoorthy <natg@google.com> Acked-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent bbd3762 commit 388d333

File tree

1 file changed

+3
-0
lines changed
  • drivers/net/ethernet/broadcom

1 file changed

+3
-0
lines changed

drivers/net/ethernet/broadcom/tg3.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16503,6 +16503,9 @@ static int tg3_get_invariants(struct tg3 *tp, const struct pci_device_id *ent)
1650316503
/* Clear this out for sanity. */
1650416504
tw32(TG3PCI_MEM_WIN_BASE_ADDR, 0);
1650516505

16506+
/* Clear TG3PCI_REG_BASE_ADDR to prevent hangs. */
16507+
tw32(TG3PCI_REG_BASE_ADDR, 0);
16508+
1650616509
pci_read_config_dword(tp->pdev, TG3PCI_PCISTATE,
1650716510
&pci_state_reg);
1650816511
if ((pci_state_reg & PCISTATE_CONV_PCI_MODE) == 0 &&

0 commit comments

Comments
 (0)