stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

Choong Yong Liang · Paolo Abeni · commit 38f13bf80130 · 2025-03-17T21:09:22.000+01:00
Fix the warning "warn: missing error code? 'ret'" in the intel_tsn_lane_is_available() function. The function now returns 0 to indicate that a TSN lane was found and returns -EINVAL when it is not found. Fixes: a42f6b3 ("net: stmmac: configure SerDes according to the interface mode") Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com> Reviewed-by: Kory Maincent <kory.maincent@bootlin.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20250310050835.808870-1-yong.liang.choong@linux.intel.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
@@ -494,10 +494,10 @@ static int intel_tsn_lane_is_available(struct net_device *ndev,
 			if ((rbuf.buf[0] >>
 				(4 * (intel_priv->tsn_lane_regs[j] % 8)) &
 					B_PCH_FIA_PCR_L0O) == 0xB)
-				return ret;
+				return 0;
 	}
 
-	return ret;
+	return -EINVAL;
 }
 
 static int intel_set_reg_access(const struct pmc_serdes_regs *regs, int max_regs)

Original file line number	Diff line number	Diff line change
`@@ -494,10 +494,10 @@ static int intel_tsn_lane_is_available(struct net_device *ndev,`
`494`	`494`	`if ((rbuf.buf[0] >>`
`495`	`495`	`(4 * (intel_priv->tsn_lane_regs[j] % 8)) &`
`496`	`496`	`B_PCH_FIA_PCR_L0O) == 0xB)`
`497`		`- return ret;`
	`497`	`+ return 0;`
`498`	`498`	`}`
`499`	`499`
`500`		`- return ret;`
	`500`	`+ return -EINVAL;`
`501`	`501`	`}`
`502`	`502`
`503`	`503`	`static int intel_set_reg_access(const struct pmc_serdes_regs *regs, int max_regs)`