Skip to content

Commit 39b0a10

Browse files
Russell King (Oracle)Paolo Abeni
authored andcommitted
net: stmmac: remove unnecessary stmmac_mac_set() in stmmac_release()
stmmac_release() calls phylink_stop() and then goes on to call stmmac_mac_set(, false). However, phylink_stop() will call stmmac_mac_link_down() before returning, which will do this work. Remove this unnecessary call. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Tested-by: Furong Xu <0x1207@gmail.com> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Link: https://patch.msgid.link/E1trcI6-005rn8-GV@rmk-PC.armlinux.org.uk Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 180fa8d commit 39b0a10

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4129,9 +4129,6 @@ static int stmmac_release(struct net_device *dev)
41294129
/* Release and free the Rx/Tx resources */
41304130
free_dma_desc_resources(priv, &priv->dma_conf);
41314131

4132-
/* Disable the MAC Rx/Tx */
4133-
stmmac_mac_set(priv, priv->ioaddr, false);
4134-
41354132
/* Powerdown Serdes if there is */
41364133
if (priv->plat->serdes_powerdown)
41374134
priv->plat->serdes_powerdown(dev, priv->plat->bsp_priv);

0 commit comments

Comments
 (0)