Skip to content

Commit 3b6fd6f

Browse files
RichardWeiYangtorvalds
authored andcommitted
drivers/base/memory.c: remove an unnecessary check on NR_MEM_SECTIONS
In cb5e39b ("drivers: base: refactor add_memory_section() to add_memory_block()"), add_memory_block() is introduced, which is only invoked in memory_dev_init(). When combining these two loops in memory_dev_init() and add_memory_block(), they looks like this: for (i = 0; i < NR_MEM_SECTIONS; i += sections_per_block) for (j = i; (j < i + sections_per_block) && j < NR_MEM_SECTIONS; j++) Since it is sure the (i < NR_MEM_SECTIONS) and j sits in its own memory block, the check of (j < NR_MEM_SECTIONS) is not necessary. This patch just removes this check. Link: http://lkml.kernel.org/r/20181123222811.18216-1-richard.weiyang@gmail.com Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Seth Jennings <sjenning@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4d72868 commit 3b6fd6f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/base/memory.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,7 @@ static int add_memory_block(int base_section_nr)
688688
int i, ret, section_count = 0, section_nr;
689689

690690
for (i = base_section_nr;
691-
(i < base_section_nr + sections_per_block) && i < NR_MEM_SECTIONS;
691+
i < base_section_nr + sections_per_block;
692692
i++) {
693693
if (!present_section_nr(i))
694694
continue;

0 commit comments

Comments
 (0)